* [PATCH] fs/ext2: Ignore checksum seed incompat feature support
@ 2021-06-11 19:36 Javier Martinez Canillas
2021-06-12 13:55 ` Mihai Moldovan
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2021-06-11 19:36 UTC (permalink / raw)
To: grub-devel
Cc: Javier Martinez Canillas, Eric Sandeen, Lukas Czerner,
Colin Walters, Dusty Mabe, Jonathan Lebon, Peter Jones
This incompat feature is used to denote that the filesystem stored its
metadata checksum seed in the superblock. This is used to allow tune2fs
to change the UUID on a mounted metadata_csum filesystem without having
to rewrite all the disk metadata.
But GRUB doesn't use the metadata checksum in anyway, so can just ignore
this feature if is enabled. This is consistent with GRUB filesystem code
in general which just does a best effort to access the filesystem's data.
It may be removed from the ignored list in the future if supports to do
metadata checksumming verification is added to the read-only FS driver.
Suggested-by: Eric Sandeen <esandeen@redhat.com>
Suggested-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
grub-core/fs/ext2.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/grub-core/fs/ext2.c b/grub-core/fs/ext2.c
index 848bf939dba..238b2d76e38 100644
--- a/grub-core/fs/ext2.c
+++ b/grub-core/fs/ext2.c
@@ -103,6 +103,7 @@ GRUB_MOD_LICENSE ("GPLv3+");
#define EXT4_FEATURE_INCOMPAT_64BIT 0x0080
#define EXT4_FEATURE_INCOMPAT_MMP 0x0100
#define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200
+#define EXT4_FEATURE_INCOMPAT_CSUM_SEED 0x2000
#define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x10000
/* The set of back-incompatible features this driver DOES support. Add (OR)
@@ -123,9 +124,16 @@ GRUB_MOD_LICENSE ("GPLv3+");
* mmp: Not really back-incompatible - was added as such to
* avoid multiple read-write mounts. Safe to ignore for this
* RO driver.
+ * checksum seed: Not really back-incompatible - was added to allow tools
+ * such as tune2fs to change the UUID on a mounted metadata
+ * checksummed filesystem. Safe to ignore for now since the
+ * driver doesn't support checksum verification. But it must
+ * be removed from this list if that support is added later.
+ *
*/
#define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \
- | EXT4_FEATURE_INCOMPAT_MMP)
+ | EXT4_FEATURE_INCOMPAT_MMP \
+ | EXT4_FEATURE_INCOMPAT_CSUM_SEED)
#define EXT3_JOURNAL_MAGIC_NUMBER 0xc03b3998U
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
2021-06-11 19:36 [PATCH] fs/ext2: Ignore checksum seed incompat feature support Javier Martinez Canillas
@ 2021-06-12 13:55 ` Mihai Moldovan
2021-06-14 13:03 ` Lukas Czerner
2021-07-07 13:22 ` Daniel Kiper
2 siblings, 0 replies; 7+ messages in thread
From: Mihai Moldovan @ 2021-06-12 13:55 UTC (permalink / raw)
To: The development of GNU GRUB, Javier Martinez Canillas
[-- Attachment #1.1: Type: text/plain, Size: 994 bytes --]
* On 6/11/21 9:36 PM, Javier Martinez Canillas wrote:
> This incompat feature is used to denote that the filesystem stored its
> metadata checksum seed in the superblock. This is used to allow tune2fs
> to change the UUID on a mounted metadata_csum filesystem without having
> to rewrite all the disk metadata.
>
> But GRUB doesn't use the metadata checksum in anyway, so can just ignore
any way
> this feature if is enabled. This is consistent with GRUB filesystem code
if it is
> in general which just does a best effort to access the filesystem's data.
>
> It may be removed from the ignored list in the future if supports to do
> metadata checksumming verification is added to the read-only FS driver.
support
or better yet:
support for
metadata checksum verification
Mihai
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
2021-06-11 19:36 [PATCH] fs/ext2: Ignore checksum seed incompat feature support Javier Martinez Canillas
2021-06-12 13:55 ` Mihai Moldovan
@ 2021-06-14 13:03 ` Lukas Czerner
2021-07-07 13:22 ` Daniel Kiper
2 siblings, 0 replies; 7+ messages in thread
From: Lukas Czerner @ 2021-06-14 13:03 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: grub-devel, Eric Sandeen, Colin Walters, Dusty Mabe,
Jonathan Lebon, Peter Jones
On Fri, Jun 11, 2021 at 09:36:16PM +0200, Javier Martinez Canillas wrote:
> This incompat feature is used to denote that the filesystem stored its
> metadata checksum seed in the superblock. This is used to allow tune2fs
> to change the UUID on a mounted metadata_csum filesystem without having
> to rewrite all the disk metadata.
>
> But GRUB doesn't use the metadata checksum in anyway, so can just ignore
> this feature if is enabled. This is consistent with GRUB filesystem code
> in general which just does a best effort to access the filesystem's data.
>
> It may be removed from the ignored list in the future if supports to do
> metadata checksumming verification is added to the read-only FS driver.
Thanks,
you can add
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
-Lukas
>
> Suggested-by: Eric Sandeen <esandeen@redhat.com>
> Suggested-by: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
>
> grub-core/fs/ext2.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/fs/ext2.c b/grub-core/fs/ext2.c
> index 848bf939dba..238b2d76e38 100644
> --- a/grub-core/fs/ext2.c
> +++ b/grub-core/fs/ext2.c
> @@ -103,6 +103,7 @@ GRUB_MOD_LICENSE ("GPLv3+");
> #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080
> #define EXT4_FEATURE_INCOMPAT_MMP 0x0100
> #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200
> +#define EXT4_FEATURE_INCOMPAT_CSUM_SEED 0x2000
> #define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x10000
>
> /* The set of back-incompatible features this driver DOES support. Add (OR)
> @@ -123,9 +124,16 @@ GRUB_MOD_LICENSE ("GPLv3+");
> * mmp: Not really back-incompatible - was added as such to
> * avoid multiple read-write mounts. Safe to ignore for this
> * RO driver.
> + * checksum seed: Not really back-incompatible - was added to allow tools
> + * such as tune2fs to change the UUID on a mounted metadata
> + * checksummed filesystem. Safe to ignore for now since the
> + * driver doesn't support checksum verification. But it must
> + * be removed from this list if that support is added later.
> + *
> */
> #define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \
> - | EXT4_FEATURE_INCOMPAT_MMP)
> + | EXT4_FEATURE_INCOMPAT_MMP \
> + | EXT4_FEATURE_INCOMPAT_CSUM_SEED)
>
>
> #define EXT3_JOURNAL_MAGIC_NUMBER 0xc03b3998U
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
2021-06-11 19:36 [PATCH] fs/ext2: Ignore checksum seed incompat feature support Javier Martinez Canillas
2021-06-12 13:55 ` Mihai Moldovan
2021-06-14 13:03 ` Lukas Czerner
@ 2021-07-07 13:22 ` Daniel Kiper
2 siblings, 0 replies; 7+ messages in thread
From: Daniel Kiper @ 2021-07-07 13:22 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: grub-devel, Eric Sandeen, Lukas Czerner, Colin Walters,
Dusty Mabe, Jonathan Lebon, Peter Jones
On Fri, Jun 11, 2021 at 09:36:16PM +0200, Javier Martinez Canillas wrote:
> This incompat feature is used to denote that the filesystem stored its
> metadata checksum seed in the superblock. This is used to allow tune2fs
> to change the UUID on a mounted metadata_csum filesystem without having
> to rewrite all the disk metadata.
>
> But GRUB doesn't use the metadata checksum in anyway, so can just ignore
> this feature if is enabled. This is consistent with GRUB filesystem code
> in general which just does a best effort to access the filesystem's data.
>
> It may be removed from the ignored list in the future if supports to do
> metadata checksumming verification is added to the read-only FS driver.
>
> Suggested-by: Eric Sandeen <esandeen@redhat.com>
> Suggested-by: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
@ 2023-08-24 22:08 Stéphane Fontaine
2023-08-24 23:24 ` Vladimir 'phcoder' Serbinenko
2023-08-29 14:09 ` Daniel Kiper
0 siblings, 2 replies; 7+ messages in thread
From: Stéphane Fontaine @ 2023-08-24 22:08 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 46 bytes --]
The patch had to be regenerated for grub 2.06
[-- Attachment #2: grub2-ignore_ext4_checksum_seed_feature.patch --]
[-- Type: text/x-patch, Size: 2033 bytes --]
Suggested-by: Eric Sandeen <esandeen@redhat.com>
Suggested-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Regenerated-by: Stephane Fontaine <esselfe16@gmail.com>
---
diff -ur grub-2.06-orig/grub-core/fs/ext2.c grub-2.06-new/grub-core/fs/ext2.c
--- grub-2.06-orig/grub-core/fs/ext2.c 2021-06-01 11:16:48.000000000 -0400
+++ grub-2.06-new/grub-core/fs/ext2.c 2023-08-24 16:54:31.890991253 -0400
@@ -103,6 +103,7 @@
#define EXT4_FEATURE_INCOMPAT_64BIT 0x0080
#define EXT4_FEATURE_INCOMPAT_MMP 0x0100
#define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200
+#define EXT4_FEATURE_INCOMPAT_CSUM_SEED 0x2000
#define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x10000
/* The set of back-incompatible features this driver DOES support. Add (OR)
@@ -112,6 +113,7 @@
| EXT4_FEATURE_INCOMPAT_FLEX_BG \
| EXT2_FEATURE_INCOMPAT_META_BG \
| EXT4_FEATURE_INCOMPAT_64BIT \
+ | EXT4_FEATURE_INCOMPAT_CSUM_SEED \
| EXT4_FEATURE_INCOMPAT_ENCRYPT)
/* List of rationales for the ignored "incompatible" features:
* needs_recovery: Not really back-incompatible - was added as such to forbid
@@ -123,6 +125,12 @@
* mmp: Not really back-incompatible - was added as such to
* avoid multiple read-write mounts. Safe to ignore for this
* RO driver.
+ * checksum seed: Not really back-incompatible - was added to allow tools
+ * such as tune2fs to change the UUID on a mounted metadata
+ * checksummed filesystem. Safe to ignore for now since the
+ * driver doesn't support checksum verification. But it must
+ * be removed from this list if that support is added later.
+ *
*/
#define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \
| EXT4_FEATURE_INCOMPAT_MMP)
[-- Attachment #3: Type: text/plain, Size: 141 bytes --]
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
2023-08-24 22:08 Stéphane Fontaine
@ 2023-08-24 23:24 ` Vladimir 'phcoder' Serbinenko
2023-08-29 14:09 ` Daniel Kiper
1 sibling, 0 replies; 7+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2023-08-24 23:24 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]
LGTM
Le ven. 25 août 2023, 00:09, Stéphane Fontaine <esselfe16@gmail.com> a
écrit :
> The patch had to be regenerated for grub 2.06
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #1.2: Type: text/html, Size: 744 bytes --]
[-- Attachment #2: Type: text/plain, Size: 141 bytes --]
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
2023-08-24 22:08 Stéphane Fontaine
2023-08-24 23:24 ` Vladimir 'phcoder' Serbinenko
@ 2023-08-29 14:09 ` Daniel Kiper
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Kiper @ 2023-08-29 14:09 UTC (permalink / raw)
To: Stéphane Fontaine; +Cc: grub-devel
On Thu, Aug 24, 2023 at 06:08:12PM -0400, Stéphane Fontaine wrote:
> The patch had to be regenerated for grub 2.06
The GRUB 2.06 is no longer maintained by upstream maintainers due to
lack of resources.
The fix is in the latest master.
Please send patches using "git send-email" next time.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-29 14:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 19:36 [PATCH] fs/ext2: Ignore checksum seed incompat feature support Javier Martinez Canillas
2021-06-12 13:55 ` Mihai Moldovan
2021-06-14 13:03 ` Lukas Czerner
2021-07-07 13:22 ` Daniel Kiper
-- strict thread matches above, loose matches on Subject: below --
2023-08-24 22:08 Stéphane Fontaine
2023-08-24 23:24 ` Vladimir 'phcoder' Serbinenko
2023-08-29 14:09 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.