From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lrmxJ-0006PI-TA for mharc-grub-devel@gnu.org; Fri, 11 Jun 2021 15:36:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrmxI-0006Ou-6J for grub-devel@gnu.org; Fri, 11 Jun 2021 15:36:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrmx6-0007i8-9w for grub-devel@gnu.org; Fri, 11 Jun 2021 15:36:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623440182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kBrUiAMs/7OYFnIAO/szLKyg3L8I4k5t6iaiza/oH1U=; b=bAzD2PHocP6H4os4g9Gl7Qlf+Sl3zDg6I99USJQpXRRE2XFpnnrQTehN6fAHb8/FCKr36r rkTH5GcjiTXGssBSRbJkA3QOH2ntfsjjg8K7TLMv2syWKmI8TmBB/yCvLBIyypBzKjOHej F1BubnyQBthBnIvQ5Ou8JlJnrzBzICY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-am-1cQpgPb6ANGKz4SIhJw-1; Fri, 11 Jun 2021 15:36:20 -0400 X-MC-Unique: am-1cQpgPb6ANGKz4SIhJw-1 Received: by mail-wm1-f72.google.com with SMTP id a25-20020a7bc1d90000b029019dd2ac7025so4645310wmj.1 for ; Fri, 11 Jun 2021 12:36:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kBrUiAMs/7OYFnIAO/szLKyg3L8I4k5t6iaiza/oH1U=; b=CjDeb6zFzVlSD3gHLOFHF97lkw5vAeXZMJdspAcGTukjvSWcqhvYXCAjE5jHWErwxC 4KyI0qo/O8q98qiCgPvFsgWxJeJYmUfokaleqXVXutVWpPcW7MsVrICwh7uYhSZca5Ss tWJcEZgU7Ob9QKwZKBA3Eed32V181/dOjYPfKUdGgmyCPwvWvAD/3P0QC6EGyF5yeNyG 3MNfpW6w3kheBSltj69mTFqHzjEr7VwcONka50DDhvnhUZaZP0S79lQE+bgjwN20hJmn fxJfAywM5Zo2M+k89ubuCk2N3a2JdxEQ+rkacieGoz9um3iVXQIxVNBXH4+HnBXeIF4J mKbQ== X-Gm-Message-State: AOAM532OOFEMkvXgv2bfId2smFU5so7rcYh8oWM5qFzQ4X0nsYbC31sW JcJ0KWwhix4ceKhAKbW7ppcwtw5AWWYNVXv8XzKdPFhCNl1mMVMbmwej0rbZAFdyG3idw4nkW+x 6Dm4DtZavhAfBXeB6bshdypwTE5CNrj26eUcdY4kK8hb+8utKFyPjjpa/THs8HA== X-Received: by 2002:a05:6000:18f:: with SMTP id p15mr5745621wrx.102.1623440179540; Fri, 11 Jun 2021 12:36:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbNuYtcLC0Iwsw/pJizu4HLATWGLMifbleRjOsng90KFQXyI0lk9T10/b4oM5ZaaX+vlpxjA== X-Received: by 2002:a05:6000:18f:: with SMTP id p15mr5745604wrx.102.1623440179358; Fri, 11 Jun 2021 12:36:19 -0700 (PDT) Received: from minerva.home ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id q3sm8074727wrz.71.2021.06.11.12.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 12:36:18 -0700 (PDT) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Javier Martinez Canillas , Eric Sandeen , Lukas Czerner , Colin Walters , Dusty Mabe , Jonathan Lebon , Peter Jones Subject: [PATCH] fs/ext2: Ignore checksum seed incompat feature support Date: Fri, 11 Jun 2021 21:36:16 +0200 Message-Id: <20210611193616.2596290-1-javierm@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=216.205.24.124; envelope-from=javierm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 19:36:36 -0000 This incompat feature is used to denote that the filesystem stored its metadata checksum seed in the superblock. This is used to allow tune2fs to change the UUID on a mounted metadata_csum filesystem without having to rewrite all the disk metadata. But GRUB doesn't use the metadata checksum in anyway, so can just ignore this feature if is enabled. This is consistent with GRUB filesystem code in general which just does a best effort to access the filesystem's data. It may be removed from the ignored list in the future if supports to do metadata checksumming verification is added to the read-only FS driver. Suggested-by: Eric Sandeen Suggested-by: Lukas Czerner Signed-off-by: Javier Martinez Canillas --- grub-core/fs/ext2.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/ext2.c b/grub-core/fs/ext2.c index 848bf939dba..238b2d76e38 100644 --- a/grub-core/fs/ext2.c +++ b/grub-core/fs/ext2.c @@ -103,6 +103,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080 #define EXT4_FEATURE_INCOMPAT_MMP 0x0100 #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200 +#define EXT4_FEATURE_INCOMPAT_CSUM_SEED 0x2000 #define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x10000 /* The set of back-incompatible features this driver DOES support. Add (OR) @@ -123,9 +124,16 @@ GRUB_MOD_LICENSE ("GPLv3+"); * mmp: Not really back-incompatible - was added as such to * avoid multiple read-write mounts. Safe to ignore for this * RO driver. + * checksum seed: Not really back-incompatible - was added to allow tools + * such as tune2fs to change the UUID on a mounted metadata + * checksummed filesystem. Safe to ignore for now since the + * driver doesn't support checksum verification. But it must + * be removed from this list if that support is added later. + * */ #define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \ - | EXT4_FEATURE_INCOMPAT_MMP) + | EXT4_FEATURE_INCOMPAT_MMP \ + | EXT4_FEATURE_INCOMPAT_CSUM_SEED) #define EXT3_JOURNAL_MAGIC_NUMBER 0xc03b3998U -- 2.31.1