From: "Stéphane Fontaine" <esselfe16@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
Date: Thu, 24 Aug 2023 18:08:12 -0400 [thread overview]
Message-ID: <CA+pKbR=+so3KVAMR+hr34v_f6XB8fEgeJrpLqkNF3kY8++XDAQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 46 bytes --]
The patch had to be regenerated for grub 2.06
[-- Attachment #2: grub2-ignore_ext4_checksum_seed_feature.patch --]
[-- Type: text/x-patch, Size: 2033 bytes --]
Suggested-by: Eric Sandeen <esandeen@redhat.com>
Suggested-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Regenerated-by: Stephane Fontaine <esselfe16@gmail.com>
---
diff -ur grub-2.06-orig/grub-core/fs/ext2.c grub-2.06-new/grub-core/fs/ext2.c
--- grub-2.06-orig/grub-core/fs/ext2.c 2021-06-01 11:16:48.000000000 -0400
+++ grub-2.06-new/grub-core/fs/ext2.c 2023-08-24 16:54:31.890991253 -0400
@@ -103,6 +103,7 @@
#define EXT4_FEATURE_INCOMPAT_64BIT 0x0080
#define EXT4_FEATURE_INCOMPAT_MMP 0x0100
#define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200
+#define EXT4_FEATURE_INCOMPAT_CSUM_SEED 0x2000
#define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x10000
/* The set of back-incompatible features this driver DOES support. Add (OR)
@@ -112,6 +113,7 @@
| EXT4_FEATURE_INCOMPAT_FLEX_BG \
| EXT2_FEATURE_INCOMPAT_META_BG \
| EXT4_FEATURE_INCOMPAT_64BIT \
+ | EXT4_FEATURE_INCOMPAT_CSUM_SEED \
| EXT4_FEATURE_INCOMPAT_ENCRYPT)
/* List of rationales for the ignored "incompatible" features:
* needs_recovery: Not really back-incompatible - was added as such to forbid
@@ -123,6 +125,12 @@
* mmp: Not really back-incompatible - was added as such to
* avoid multiple read-write mounts. Safe to ignore for this
* RO driver.
+ * checksum seed: Not really back-incompatible - was added to allow tools
+ * such as tune2fs to change the UUID on a mounted metadata
+ * checksummed filesystem. Safe to ignore for now since the
+ * driver doesn't support checksum verification. But it must
+ * be removed from this list if that support is added later.
+ *
*/
#define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER \
| EXT4_FEATURE_INCOMPAT_MMP)
[-- Attachment #3: Type: text/plain, Size: 141 bytes --]
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next reply other threads:[~2023-08-24 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 22:08 Stéphane Fontaine [this message]
2023-08-24 23:24 ` [PATCH] fs/ext2: Ignore checksum seed incompat feature support Vladimir 'phcoder' Serbinenko
2023-08-29 14:09 ` Daniel Kiper
-- strict thread matches above, loose matches on Subject: below --
2021-06-11 19:36 Javier Martinez Canillas
2021-06-12 13:55 ` Mihai Moldovan
2021-06-14 13:03 ` Lukas Czerner
2021-07-07 13:22 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+pKbR=+so3KVAMR+hr34v_f6XB8fEgeJrpLqkNF3kY8++XDAQ@mail.gmail.com' \
--to=esselfe16@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.