From: Daniel Kiper <dkiper@net-space.pl>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: grub-devel@gnu.org, Eric Sandeen <esandeen@redhat.com>,
Lukas Czerner <lczerner@redhat.com>,
Colin Walters <walters@redhat.com>,
Dusty Mabe <dustymabe@redhat.com>,
Jonathan Lebon <jlebon@redhat.com>,
Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support
Date: Wed, 7 Jul 2021 15:22:17 +0200 [thread overview]
Message-ID: <20210707132217.cnzunfe4tdy266ki@tomti.i.net-space.pl> (raw)
In-Reply-To: <20210611193616.2596290-1-javierm@redhat.com>
On Fri, Jun 11, 2021 at 09:36:16PM +0200, Javier Martinez Canillas wrote:
> This incompat feature is used to denote that the filesystem stored its
> metadata checksum seed in the superblock. This is used to allow tune2fs
> to change the UUID on a mounted metadata_csum filesystem without having
> to rewrite all the disk metadata.
>
> But GRUB doesn't use the metadata checksum in anyway, so can just ignore
> this feature if is enabled. This is consistent with GRUB filesystem code
> in general which just does a best effort to access the filesystem's data.
>
> It may be removed from the ignored list in the future if supports to do
> metadata checksumming verification is added to the read-only FS driver.
>
> Suggested-by: Eric Sandeen <esandeen@redhat.com>
> Suggested-by: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
next prev parent reply other threads:[~2021-07-07 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 19:36 [PATCH] fs/ext2: Ignore checksum seed incompat feature support Javier Martinez Canillas
2021-06-12 13:55 ` Mihai Moldovan
2021-06-14 13:03 ` Lukas Czerner
2021-07-07 13:22 ` Daniel Kiper [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-24 22:08 Stéphane Fontaine
2023-08-24 23:24 ` Vladimir 'phcoder' Serbinenko
2023-08-29 14:09 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707132217.cnzunfe4tdy266ki@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=dustymabe@redhat.com \
--cc=esandeen@redhat.com \
--cc=grub-devel@gnu.org \
--cc=javierm@redhat.com \
--cc=jlebon@redhat.com \
--cc=lczerner@redhat.com \
--cc=pjones@redhat.com \
--cc=walters@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.