From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m17VT-0001op-ML for mharc-grub-devel@gnu.org; Wed, 07 Jul 2021 09:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m17VR-0001nE-He for grub-devel@gnu.org; Wed, 07 Jul 2021 09:22:26 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:36575) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1m17VP-000216-Pc for grub-devel@gnu.org; Wed, 07 Jul 2021 09:22:25 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:35884 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S1836732AbhGGNWU (ORCPT ); Wed, 7 Jul 2021 15:22:20 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Wed, 7 Jul 2021 15:22:17 +0200 From: Daniel Kiper To: Javier Martinez Canillas Cc: grub-devel@gnu.org, Eric Sandeen , Lukas Czerner , Colin Walters , Dusty Mabe , Jonathan Lebon , Peter Jones Subject: Re: [PATCH] fs/ext2: Ignore checksum seed incompat feature support Message-ID: <20210707132217.cnzunfe4tdy266ki@tomti.i.net-space.pl> References: <20210611193616.2596290-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611193616.2596290-1-javierm@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 13:22:26 -0000 On Fri, Jun 11, 2021 at 09:36:16PM +0200, Javier Martinez Canillas wrote: > This incompat feature is used to denote that the filesystem stored its > metadata checksum seed in the superblock. This is used to allow tune2fs > to change the UUID on a mounted metadata_csum filesystem without having > to rewrite all the disk metadata. > > But GRUB doesn't use the metadata checksum in anyway, so can just ignore > this feature if is enabled. This is consistent with GRUB filesystem code > in general which just does a best effort to access the filesystem's data. > > It may be removed from the ignored list in the future if supports to do > metadata checksumming verification is added to the read-only FS driver. > > Suggested-by: Eric Sandeen > Suggested-by: Lukas Czerner > Signed-off-by: Javier Martinez Canillas Reviewed-by: Daniel Kiper Daniel