From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: Dorjoy Chowdhury <dorjoychy111@gmail.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT
Date: Thu, 2 May 2024 15:11:10 +0200 [thread overview]
Message-ID: <c696603d-b8dc-4fed-96f0-da40c6ce8287@linaro.org> (raw)
In-Reply-To: <CAFfO_h6-RXettxqnCYciDrq6ivsTHtM55FcksJSUNnLdbio4mg@mail.gmail.com>
W dniu 2.05.2024 o 15:04, Dorjoy Chowdhury pisze:
>> Should "return" also have "(1 << 24) |" to have MT=1 set?
>>
>> Otherwise MPIDR_EL1 = 0x000100 can mean core0 in cluster1 or core1 in
>> cluster0.
>>
>> Value 0x1000100 shows MT=1 so thread0 in core1 in cluster0.
> I don't know all the details but from what I understand the
> "arm_build_mp_afiinity" is used to set the "mp_affinity" member
> variable which I assume is about affinity, not the whole MPIDR
> register value. That is what I assumed because the Uniprocessor
> indication bit(30) is being set only in the "mpidr_read_val" function.
> In the patch, the MT bit is also being set in the "mpidr_read_val"
> function based on the SMT status (has_smt) of the CPU.
mpidr_read_val() is used only to set VMPIDR and VMPIDR_EL2 registers.
So setting MT bit for MPIDR_EL1 needs to be added somewhere.
next prev parent reply other threads:[~2024-05-02 13:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 18:31 [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT Dorjoy Chowdhury
2024-04-21 5:40 ` Richard Henderson
2024-04-21 8:40 ` Dorjoy Chowdhury
2024-04-22 10:46 ` Peter Maydell
2024-04-22 11:26 ` Peter Maydell
2024-04-22 15:21 ` Richard Henderson
2024-04-22 15:24 ` Richard Henderson
2024-05-01 18:08 ` Marcin Juszkiewicz
2024-05-02 9:11 ` Peter Maydell
2024-05-02 10:37 ` Peter Maydell
2024-05-02 10:56 ` Marcin Juszkiewicz
2024-05-02 11:40 ` Peter Maydell
2024-04-25 16:46 ` Dorjoy Chowdhury
2024-05-02 12:14 ` Marcin Juszkiewicz
2024-05-02 13:04 ` Dorjoy Chowdhury
2024-05-02 13:11 ` Marcin Juszkiewicz [this message]
2024-05-02 13:13 ` Peter Maydell
2024-05-02 13:50 ` Marcin Juszkiewicz
2024-05-02 13:57 ` Peter Maydell
2024-05-03 16:28 ` Peter Maydell
2024-05-03 16:52 ` Dorjoy Chowdhury
2024-05-31 12:52 ` Peter Maydell
2024-05-31 13:46 ` Dorjoy Chowdhury
2024-05-03 18:14 ` Dorjoy Chowdhury
2024-05-04 13:31 ` Peter Maydell
2024-05-04 14:20 ` Dorjoy Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c696603d-b8dc-4fed-96f0-da40c6ce8287@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=dorjoychy111@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).