* [PATCH] httpd: do not sort CSV output by default
@ 2023-01-09 5:58 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-01-09 5:58 UTC (permalink / raw)
To: mwrap-public
CSV output is intended to be loaded by something else
(e.g. SQLite, spreadsheet program, etc), so sorting it
is likely a waste of time.
---
ext/mwrap/httpd.h | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ext/mwrap/httpd.h b/ext/mwrap/httpd.h
index 5c3b83f..17fb187 100644
--- a/ext/mwrap/httpd.h
+++ b/ext/mwrap/httpd.h
@@ -609,8 +609,13 @@ static enum mw_qev each_gt(struct mw_h1 *h1, struct mw_h1req *h1r,
unsigned long min, bool csv)
{
static const char default_sort[] = "bytes";
- const char *sort = default_sort;
- size_t sort_len = sizeof(default_sort) - 1;
+ const char *sort;
+ size_t sort_len = 0;
+
+ if (!csv) {
+ sort = default_sort;
+ sort_len = sizeof(default_sort) - 1;
+ }
if (h1r->qstr && h1r->qlen > 5 && !memcmp(h1r->qstr, "sort=", 5)) {
sort = h1r->qstr + 5;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-09 5:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09 5:58 [PATCH] httpd: do not sort CSV output by default Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).