From: Eric Wong <e@80x24.org>
To: mwrap-public@80x24.org
Subject: [PATCH] httpd: do not sort CSV output by default
Date: Mon, 9 Jan 2023 05:58:22 +0000 [thread overview]
Message-ID: <20230109055822.2542770-1-e@80x24.org> (raw)
CSV output is intended to be loaded by something else
(e.g. SQLite, spreadsheet program, etc), so sorting it
is likely a waste of time.
---
ext/mwrap/httpd.h | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/ext/mwrap/httpd.h b/ext/mwrap/httpd.h
index 5c3b83f..17fb187 100644
--- a/ext/mwrap/httpd.h
+++ b/ext/mwrap/httpd.h
@@ -609,8 +609,13 @@ static enum mw_qev each_gt(struct mw_h1 *h1, struct mw_h1req *h1r,
unsigned long min, bool csv)
{
static const char default_sort[] = "bytes";
- const char *sort = default_sort;
- size_t sort_len = sizeof(default_sort) - 1;
+ const char *sort;
+ size_t sort_len = 0;
+
+ if (!csv) {
+ sort = default_sort;
+ sort_len = sizeof(default_sort) - 1;
+ }
if (h1r->qstr && h1r->qlen > 5 && !memcmp(h1r->qstr, "sort=", 5)) {
sort = h1r->qstr + 5;
reply other threads:[~2023-01-09 5:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109055822.2542770-1-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).