From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9975C1F47C for ; Mon, 9 Jan 2023 05:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1673243902; bh=lzXJGG0XowZrRJkT58kdJWQcWiHcYf8Ms3AUCRk347Y=; h=From:To:Subject:Date:From; b=3X+8sCefLGqZcUPp7lK/5pEpweRSht++ZRpfxyQEZ3oEadacuojTFQ9ngNKcwLDyj MzEahgRAM/d6nHAlZ537u8OvYbQnx0lRJbVGFgvBYJoMFry2GQHgmDMxd2N88xBZ7i tYMoYTkJGMG9ssR1YKyjJKddyYNw7an4utI6iYpM= From: Eric Wong To: mwrap-public@80x24.org Subject: [PATCH] httpd: do not sort CSV output by default Date: Mon, 9 Jan 2023 05:58:22 +0000 Message-Id: <20230109055822.2542770-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: CSV output is intended to be loaded by something else (e.g. SQLite, spreadsheet program, etc), so sorting it is likely a waste of time. --- ext/mwrap/httpd.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ext/mwrap/httpd.h b/ext/mwrap/httpd.h index 5c3b83f..17fb187 100644 --- a/ext/mwrap/httpd.h +++ b/ext/mwrap/httpd.h @@ -609,8 +609,13 @@ static enum mw_qev each_gt(struct mw_h1 *h1, struct mw_h1req *h1r, unsigned long min, bool csv) { static const char default_sort[] = "bytes"; - const char *sort = default_sort; - size_t sort_len = sizeof(default_sort) - 1; + const char *sort; + size_t sort_len = 0; + + if (!csv) { + sort = default_sort; + sort_len = sizeof(default_sort) - 1; + } if (h1r->qstr && h1r->qlen > 5 && !memcmp(h1r->qstr, "sort=", 5)) { sort = h1r->qstr + 5;