* [PATCH] memalign: perform rcu_read_unlock on ENOMEM
@ 2022-08-09 0:19 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-08-09 0:19 UTC (permalink / raw)
To: mwrap-public
We must not forget to release RCU read locks even if the
process will probably die, soon, due to ENOMEM.
I noticed this while working on the Perl5/XS port.
Link: https://80x24.org/mwrap-perl/20191102020331.28050-4-e@80x24.org/
---
ext/mwrap/mwrap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index 2ee04a5..4575e34 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -632,9 +632,9 @@ internal_memalign(void **pp, size_t alignment, size_t size, uintptr_t caller)
p = ptr_align(p, alignment);
h = ptr2hdr(p);
alloc_insert_rcu(l, h, size, real);
- update_stats_rcu_unlock(l);
*pp = p;
}
+ update_stats_rcu_unlock(l);
}
return real ? 0 : ENOMEM;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-09 0:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-09 0:19 [PATCH] memalign: perform rcu_read_unlock on ENOMEM Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).