From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 3/7] memalign: perform rcu_read_unlock on ENOMEM
Date: Sat, 2 Nov 2019 02:03:27 +0000 [thread overview]
Message-ID: <20191102020331.28050-4-e@80x24.org> (raw)
In-Reply-To: <20191102020331.28050-1-e@80x24.org>
We must not forget to release RCU read locks even if the
process will probably die, soon, due to ENOMEM.
---
Mwrap.xs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Mwrap.xs b/Mwrap.xs
index f902468..92fc4de 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -459,9 +459,9 @@ internal_memalign(void **pp, size_t alignment, size_t size, uintptr_t caller)
p = ptr_align(p, alignment);
h = ptr2hdr(p);
alloc_insert_rcu(l, h, size, real);
- update_stats_rcu_unlock(l);
*pp = p;
}
+ update_stats_rcu_unlock(l);
return real ? 0 : ENOMEM;
}
next prev parent reply other threads:[~2019-11-02 2:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 2:03 [PATCH 0/7] updates while I learn XS and perlapi Eric Wong
2019-11-02 2:03 ` [PATCH 1/7] allow using "-d:Mwrap" from the command-line Eric Wong
2019-11-02 2:03 ` [PATCH 2/7] use ppport.h for caller_cx with older Perl versions Eric Wong
2019-11-02 2:03 ` Eric Wong [this message]
2019-11-02 2:03 ` [PATCH 4/7] update_stats_rcu_lock: favor PL_curcop instead of caller_cx Eric Wong
2019-11-02 2:03 ` [PATCH 5/7] script/mwrap-perl: more portable Mwrap.so detection Eric Wong
2019-11-02 2:03 ` [PATCH 6/7] support Devel::Mwrap::each with callback Eric Wong
2019-11-02 2:03 ` [PATCH 7/7] t/mwrap: don't dump unless we check the output Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191102020331.28050-4-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).