From: Eric Wong <e@80x24.org>
To: mwrap-public@80x24.org
Subject: [PATCH] memalign: perform rcu_read_unlock on ENOMEM
Date: Tue, 9 Aug 2022 00:19:11 +0000 [thread overview]
Message-ID: <20220809001911.2014877-1-e@80x24.org> (raw)
We must not forget to release RCU read locks even if the
process will probably die, soon, due to ENOMEM.
I noticed this while working on the Perl5/XS port.
Link: https://80x24.org/mwrap-perl/20191102020331.28050-4-e@80x24.org/
---
ext/mwrap/mwrap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index 2ee04a5..4575e34 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -632,9 +632,9 @@ internal_memalign(void **pp, size_t alignment, size_t size, uintptr_t caller)
p = ptr_align(p, alignment);
h = ptr2hdr(p);
alloc_insert_rcu(l, h, size, real);
- update_stats_rcu_unlock(l);
*pp = p;
}
+ update_stats_rcu_unlock(l);
}
return real ? 0 : ENOMEM;
reply other threads:[~2022-08-09 0:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809001911.2014877-1-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).