From: Bin Meng <bmeng.cn@gmail.com>
To: Ruinland Chuan-Tzu Tsai <ruinland@andestech.com>
Cc: Dylan Jhong <dylan@andestech.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
Alan Kao <alankao@andestech.com>,
wangjunqiang <wangjunqiang@iscas.ac.cn>,
Bin Meng <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Alistair Francis <alistair23@gmail.com>
Subject: Re: [RFC PATCH v3 1/2] Adding Andes AX25 CPU model
Date: Fri, 11 Jun 2021 07:22:21 +0800 [thread overview]
Message-ID: <CAEUhbmVJCLU1EmO4taMpGbVbsdrZyH9CRd-esMj6k9nh2aFH+g@mail.gmail.com> (raw)
In-Reply-To: <20210610144424.8658-2-ruinland@andestech.com>
Hi Ruinland,
On Thu, Jun 10, 2021 at 10:45 PM Ruinland Chuan-Tzu Tsai
<ruinland@andestech.com> wrote:
>
> From: Ruinaldn ChuanTzu Tsai <ruinland@andestech.com>
>
> Adding the skeleton of Andes Technology AX25 CPU model for the future commits,
> which will utilize custom/vendor CSR handling mechaism.
typo: mechanism
> ---
> target/riscv/cpu.c | 8 ++++++++
> target/riscv/cpu.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index ddea8fbeeb..4ae21cbf9b 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -159,6 +159,13 @@ static void rv64_base_cpu_init(Object *obj)
> set_misa(env, RV64);
> }
>
> +static void ax25_cpu_init(Object *obj)
> +{
> + CPURISCVState *env = &RISCV_CPU(obj)->env;
> + set_misa(env, RV64 | RVI | RVM | RVA | RVF | RVD | RVC | RVS | RVU);
> + set_priv_version(env, PRIV_VERSION_1_10_0);
> +}
> +
> static void rv64_sifive_u_cpu_init(Object *obj)
> {
> CPURISCVState *env = &RISCV_CPU(obj)->env;
> @@ -705,6 +712,7 @@ static const TypeInfo riscv_cpu_type_infos[] = {
> DEFINE_CPU(TYPE_RISCV_CPU_SIFIVE_U34, rv32_sifive_u_cpu_init),
> #elif defined(TARGET_RISCV64)
> DEFINE_CPU(TYPE_RISCV_CPU_BASE64, rv64_base_cpu_init),
> + DEFINE_CPU(TYPE_RISCV_CPU_AX25, ax25_cpu_init),
What about the 32-bit variant of A25, and the SMP variant of A25MP/AX25MP?
Also how about the latest A45 (RV32) and AX45 (RV64)?
How should we name these? I think we may need to name this using the
SMP variant name, no?
> DEFINE_CPU(TYPE_RISCV_CPU_SIFIVE_E51, rv64_sifive_e_cpu_init),
> DEFINE_CPU(TYPE_RISCV_CPU_SIFIVE_U54, rv64_sifive_u_cpu_init),
> #endif
Regards,
Bin
next prev parent reply other threads:[~2021-06-10 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 14:44 [RFC PATCH v3 0/2] Proposing custom CSR handling logic Ruinland Chuan-Tzu Tsai
2021-06-10 14:44 ` [RFC PATCH v3 1/2] Adding Andes AX25 CPU model Ruinland Chuan-Tzu Tsai
2021-06-10 22:49 ` Alistair Francis
2021-06-10 23:22 ` Bin Meng [this message]
2021-06-10 14:44 ` [RFC PATCH v3 2/2] Adding preliminary custom/vendor CSR handling mechanism Ruinland Chuan-Tzu Tsai
2021-06-10 16:19 ` Richard Henderson
2021-06-10 22:57 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUhbmVJCLU1EmO4taMpGbVbsdrZyH9CRd-esMj6k9nh2aFH+g@mail.gmail.com \
--to=bmeng.cn@gmail.com \
--cc=alankao@andestech.com \
--cc=alistair23@gmail.com \
--cc=bin.meng@windriver.com \
--cc=dylan@andestech.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=ruinland@andestech.com \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).