From: Michael Tokarev <mjt@tls.msk.ru>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, zack@buhman.org, peter.maydell@linaro.org,
"Cole Robinson" <crobinso@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw]
Date: Mon, 6 May 2024 15:46:21 +0300 [thread overview]
Message-ID: <6f173b24-3efc-40ce-bd96-7ac7852b91fa@tls.msk.ru> (raw)
In-Reply-To: <87o79j15f9.wl-ysato@users.sourceforge.jp>
06.05.2024 15:38, Yoshinori Sato wrote:
[...]
> Does this mean you changed it like this?
> I think this is fine.
Yes, the main part is exactly like this, and there's no questions here.
My question was more about was the testsuite changes which comes with
the same patch, and parts of the Makefile there, which requires other
patches too, at least to apply more or less cleanly.
Thanks,
/mjt
> index 7db3468b01..f3bf0fc50a 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -844,9 +844,9 @@ static void _decode_opc(DisasContext * ctx)
> {
> TCGv arg0, arg1;
> arg0 = tcg_temp_new();
> - tcg_gen_qemu_ld_i32(arg0, REG(B7_4), ctx->memidx, MO_TESL);
> + tcg_gen_qemu_ld_i32(arg0, REG(B7_4), ctx->memidx, MO_TESW);
> arg1 = tcg_temp_new();
> - tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, MO_TESL);
> + tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, MO_TESW);
> gen_helper_macw(cpu_env, arg0, arg1);
> tcg_temp_free(arg1);
> tcg_temp_free(arg0);
>
--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
prev parent reply other threads:[~2024-05-06 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 5:37 [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Richard Henderson
2024-04-06 5:37 ` [PATCH v3 1/4] target/sh4: mac.w: memory accesses are 16-bit words Richard Henderson
2024-04-06 5:37 ` [PATCH v3 2/4] target/sh4: Merge mach and macl into a union Richard Henderson
2024-04-08 6:07 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 3/4] target/sh4: Fix mac.l with saturation enabled Richard Henderson
2024-04-08 6:06 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 4/4] target/sh4: Fix mac.w " Richard Henderson
2024-04-08 6:08 ` Philippe Mathieu-Daudé
2024-05-04 8:25 ` [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Michael Tokarev
2024-05-06 12:38 ` Yoshinori Sato
2024-05-06 12:46 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f173b24-3efc-40ce-bd96-7ac7852b91fa@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=crobinso@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
--cc=zack@buhman.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).