From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: zack@buhman.org, peter.maydell@linaro.org, ysato@users.sourceforge.jp
Subject: Re: [PATCH v3 4/4] target/sh4: Fix mac.w with saturation enabled
Date: Mon, 8 Apr 2024 08:08:36 +0200 [thread overview]
Message-ID: <6e5d5d31-24ab-4284-b26f-66e429f8fc54@linaro.org> (raw)
In-Reply-To: <20240406053732.191398-5-richard.henderson@linaro.org>
On 6/4/24 07:37, Richard Henderson wrote:
> From: Zack Buhman <zack@buhman.org>
>
> The saturation arithmetic logic in helper_macw is not correct.
> I tested and verified this behavior on a SH7091.
>
> Signed-off-by: Zack Buhman <zack@buhman.org>
> Message-Id: <20240405233802.29128-3-zack@buhman.org>
> [rth: Reformat helper_macw, add a test case.]
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/sh4/helper.h | 2 +-
> target/sh4/op_helper.c | 28 +++++++++-------
> tests/tcg/sh4/test-macw.c | 61 +++++++++++++++++++++++++++++++++++
> tests/tcg/sh4/Makefile.target | 3 ++
> 4 files changed, 82 insertions(+), 12 deletions(-)
> create mode 100644 tests/tcg/sh4/test-macw.c
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-08 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 5:37 [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Richard Henderson
2024-04-06 5:37 ` [PATCH v3 1/4] target/sh4: mac.w: memory accesses are 16-bit words Richard Henderson
2024-04-06 5:37 ` [PATCH v3 2/4] target/sh4: Merge mach and macl into a union Richard Henderson
2024-04-08 6:07 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 3/4] target/sh4: Fix mac.l with saturation enabled Richard Henderson
2024-04-08 6:06 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 4/4] target/sh4: Fix mac.w " Richard Henderson
2024-04-08 6:08 ` Philippe Mathieu-Daudé [this message]
2024-05-04 8:25 ` [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Michael Tokarev
2024-05-06 12:38 ` Yoshinori Sato
2024-05-06 12:46 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e5d5d31-24ab-4284-b26f-66e429f8fc54@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
--cc=zack@buhman.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).