From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: zack@buhman.org, peter.maydell@linaro.org, ysato@users.sourceforge.jp
Subject: [PATCH v3 2/4] target/sh4: Merge mach and macl into a union
Date: Fri, 5 Apr 2024 19:37:30 -1000 [thread overview]
Message-ID: <20240406053732.191398-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240406053732.191398-1-richard.henderson@linaro.org>
Allow host access to the entire 64-bit accumulator.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sh4/cpu.h | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h
index 9211da6bde..d928bcf006 100644
--- a/target/sh4/cpu.h
+++ b/target/sh4/cpu.h
@@ -155,12 +155,22 @@ typedef struct CPUArchState {
uint32_t pc; /* program counter */
uint32_t delayed_pc; /* target of delayed branch */
uint32_t delayed_cond; /* condition of delayed branch */
- uint32_t mach; /* multiply and accumulate high */
- uint32_t macl; /* multiply and accumulate low */
uint32_t pr; /* procedure register */
uint32_t fpscr; /* floating point status/control register */
uint32_t fpul; /* floating point communication register */
+ /* multiply and accumulate: high, low and combined. */
+ union {
+ uint64_t mac;
+ struct {
+#if HOST_BIG_ENDIAN
+ uint32_t mach, macl;
+#else
+ uint32_t macl, mach;
+#endif
+ };
+ };
+
/* float point status register */
float_status fp_status;
--
2.34.1
next prev parent reply other threads:[~2024-04-06 5:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 5:37 [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Richard Henderson
2024-04-06 5:37 ` [PATCH v3 1/4] target/sh4: mac.w: memory accesses are 16-bit words Richard Henderson
2024-04-06 5:37 ` Richard Henderson [this message]
2024-04-08 6:07 ` [PATCH v3 2/4] target/sh4: Merge mach and macl into a union Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 3/4] target/sh4: Fix mac.l with saturation enabled Richard Henderson
2024-04-08 6:06 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 4/4] target/sh4: Fix mac.w " Richard Henderson
2024-04-08 6:08 ` Philippe Mathieu-Daudé
2024-05-04 8:25 ` [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Michael Tokarev
2024-05-06 12:38 ` Yoshinori Sato
2024-05-06 12:46 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240406053732.191398-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
--cc=zack@buhman.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).