From: Michael Tokarev <mjt@tls.msk.ru>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: zack@buhman.org, peter.maydell@linaro.org,
ysato@users.sourceforge.jp, "Cole Robinson" <crobinso@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw]
Date: Sat, 4 May 2024 11:25:52 +0300 [thread overview]
Message-ID: <26711de4-180b-4448-8d79-30efec984900@tls.msk.ru> (raw)
In-Reply-To: <20240406053732.191398-1-richard.henderson@linaro.org>
06.04.2024 08:37, Richard Henderson wrote:
> Zack's recent patches, tidied a little bit, and with
> test cases added.
These fixes ended up in stable-8.2, but not in stable-7.2.
This is because in 7.2, the context is a bit different.
Later, a couple other fixes in this area come from Philippe
(Fix ADDV & SUBV opcodes) which are easy to pick up but it
wants changes in tests/tcg/sh4/Makefile.target introduced
in this patchset.
b0f2f2976b "target/sh4: mac.w: memory accesses are 16-bit words"
also needs 03a0d87e8d "target/sh4: Use MO_ALIGN where required",
but this one, while simple, is a big one and doesn't apply to
7.2 directly in many places in target/sh4/translate.c, in parts
due to bebd5cb300 "target/sh4: Drop tcg_temp_free" (but can be
easily tweaked manually).
Or I can hand-apply b0f2f2976b (s/MO_TESL/MO_TESW) without
03a0d87e8d (add MO_ALIGN).
Does picking up this stuff for 7.2 make sense?
(Cc'ing Cole for general stable-7.2 feedback on redhat side).
Thanks,
/mjt
> Richard Henderson (1):
> target/sh4: Merge mach and macl into a union
>
> Zack Buhman (3):
> target/sh4: mac.w: memory accesses are 16-bit words
> target/sh4: Fix mac.l with saturation enabled
> target/sh4: Fix mac.w with saturation enabled
>
> target/sh4/cpu.h | 14 ++++++--
> target/sh4/helper.h | 4 +--
> target/sh4/op_helper.c | 51 +++++++++++++++-----------
> target/sh4/translate.c | 4 +--
> tests/tcg/sh4/test-macl.c | 67 +++++++++++++++++++++++++++++++++++
> tests/tcg/sh4/test-macw.c | 61 +++++++++++++++++++++++++++++++
> tests/tcg/sh4/Makefile.target | 8 +++++
> 7 files changed, 182 insertions(+), 27 deletions(-)
> create mode 100644 tests/tcg/sh4/test-macl.c
> create mode 100644 tests/tcg/sh4/test-macw.c
>
--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
next prev parent reply other threads:[~2024-05-04 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 5:37 [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Richard Henderson
2024-04-06 5:37 ` [PATCH v3 1/4] target/sh4: mac.w: memory accesses are 16-bit words Richard Henderson
2024-04-06 5:37 ` [PATCH v3 2/4] target/sh4: Merge mach and macl into a union Richard Henderson
2024-04-08 6:07 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 3/4] target/sh4: Fix mac.l with saturation enabled Richard Henderson
2024-04-08 6:06 ` Philippe Mathieu-Daudé
2024-04-06 5:37 ` [PATCH v3 4/4] target/sh4: Fix mac.w " Richard Henderson
2024-04-08 6:08 ` Philippe Mathieu-Daudé
2024-05-04 8:25 ` Michael Tokarev [this message]
2024-05-06 12:38 ` [PATCH for-9.0 v3 0/4] target/sh4: Fix mac.[lw] Yoshinori Sato
2024-05-06 12:46 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26711de4-180b-4448-8d79-30efec984900@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=crobinso@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
--cc=zack@buhman.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).