Git Mailing List Archive mirror
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox.com>
To: "Alejandro R Sedeño" <asedeno@google.com>
Cc: asedeno@mit.edu, git@vger.kernel.org, newren@gmail.com,
	sunshine@sunshineco.com
Subject: Re: [PATCH] statinfo.h: move DTYPE defines from dir.h
Date: Sat, 03 Jun 2023 10:56:12 +0900	[thread overview]
Message-ID: <xmqqilc571hf.fsf@gitster.g> (raw)
In-Reply-To: <20230602192700.1548636-1-asedeno@google.com> ("Alejandro R Sedeño"'s message of "Fri, 2 Jun 2023 15:27:00 -0400")

"Alejandro R Sedeño" <asedeno@google.com> writes:

> From: Alejandro R. Sedeño <asedeno@mit.edu>
>
> These definitions are used in cache.h, which can't include dir.h
> without causing name-hash.c to have two definitions of
> `struct dir_entry`.
>
> Both dir.h and cache.h include statinfo.h, and this seems a reasonable
> place for these definitions.
>
> This change fixes a broken build issue on old SunOS.
>
> Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> Signed-off-by: Alejandro R Sedeño <asedeno@google.com>

This is a bit unusual; do you want to publish both names (I am
assuming that they are the same single person)?

I thought somebody in the earlier discussion identified the topic
that was problematic by bisecting.  It is a shame to lose that.
Perhaps it is a good idea to rephrase the beginning of the proposed
commit log message to mention that, like

    592fc5b3 (dir.h: move DTYPE defines from cache.h, 2023-04-22)
    moved DTYPE macros from cache.h to dir.h, but are still used
    by cache.h to implement ce_to_dtype(); but cache.h cannot
    include dir.h because ...

or something?

Why does name-hash.c end up with two definitions?  Aren't we
properly guarding against multiple inclusions with 

    #ifndef __DIR_H__
    #define __DIR_H__
	...
    struct dir_entry {
	...
    };
    #endif

or is there something funny going on?

Thanks.

next prev parent reply	other threads:[~2023-06-03  1:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 18:45 [PATCH] statinfo.h: move DTYPE defines from dir.h Aleajndro R Sedeño
2023-06-02 18:50 ` Alejandro Sedeño
2023-06-02 19:06 ` Eric Sunshine
2023-06-02 19:21   ` Alejandro Sedeño
2023-06-02 19:27     ` Alejandro R Sedeño
2023-06-03  1:47       ` Elijah Newren
2023-06-03  1:56       ` Junio C Hamano [this message]
2023-06-03  2:04         ` Elijah Newren
2023-06-03  2:30           ` Junio C Hamano
2023-06-03  3:02         ` Alejandro Sedeño
2023-06-06 20:59         ` Alejandro R Sedeño
2023-06-12 18:00           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqilc571hf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=asedeno@google.com \
    --cc=asedeno@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).