From: "Alejandro Sedeño" <asedeno@google.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Elijah Newren" <newren@gmail.com>,
"Alejandro R. Sedeño" <asedeno@mit.edu>
Subject: Re: [PATCH] statinfo.h: move DTYPE defines from dir.h
Date: Fri, 2 Jun 2023 15:21:28 -0400 [thread overview]
Message-ID: <CALVMLfLw4P=VnBOYA-WbHRNPZiAiO05h4k+cSvPJuaqkjgp5ew@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cS0sGYiCa9Og-f-UL=pZo9OAz587UsdX69BCf7hraHWFA@mail.gmail.com>
That is a valid question, and it's another typo. I meant name-hash.c.
-Alejandro
On Fri, Jun 2, 2023 at 3:06 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Fri, Jun 2, 2023 at 3:03 PM Aleajndro R Sedeño <asedeno@google.com> wrote:
> > These definitions are used in cache.h, which can't include dir.h
> > without causing name-info.cc to have two definitions of
> > `struct dir_entry`.
>
> What is `name-info.cc`?
>
> > Both dir.h and cache.h include statinfo.h, and this seems a reasonable
> > place for these definitions.
> >
> > This change fixes a broken build issue on old SunOS.
> >
> > Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> > Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
next prev parent reply other threads:[~2023-06-02 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 18:45 [PATCH] statinfo.h: move DTYPE defines from dir.h Aleajndro R Sedeño
2023-06-02 18:50 ` Alejandro Sedeño
2023-06-02 19:06 ` Eric Sunshine
2023-06-02 19:21 ` Alejandro Sedeño [this message]
2023-06-02 19:27 ` Alejandro R Sedeño
2023-06-03 1:47 ` Elijah Newren
2023-06-03 1:56 ` Junio C Hamano
2023-06-03 2:04 ` Elijah Newren
2023-06-03 2:30 ` Junio C Hamano
2023-06-03 3:02 ` Alejandro Sedeño
2023-06-06 20:59 ` Alejandro R Sedeño
2023-06-12 18:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALVMLfLw4P=VnBOYA-WbHRNPZiAiO05h4k+cSvPJuaqkjgp5ew@mail.gmail.com' \
--to=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).