From: Elijah Newren <newren@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Alejandro R Sedeño" <asedeno@google.com>,
asedeno@mit.edu, git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH] statinfo.h: move DTYPE defines from dir.h
Date: Fri, 2 Jun 2023 19:04:31 -0700 [thread overview]
Message-ID: <CABPp-BHZ6a8VEuK=miMAcBG9RbUz+epuQ+d1xvwbRj_tsnYqcQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqilc571hf.fsf@gitster.g>
On Fri, Jun 2, 2023 at 6:56 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Why does name-hash.c end up with two definitions? Aren't we
> properly guarding against multiple inclusions with
>
> #ifndef __DIR_H__
> #define __DIR_H__
> ...
> struct dir_entry {
> ...
> };
> #endif
>
> or is there something funny going on?
There are two _different_ things named "struct dir_entry" in the codebase:
dir.h:struct dir_entry {
dir.h- unsigned int len;
dir.h- char name[FLEX_ARRAY]; /* more */
dir.h-};
--
name-hash.c:struct dir_entry {
name-hash.c- struct hashmap_entry ent;
name-hash.c- struct dir_entry *parent;
name-hash.c- int nr;
name-hash.c- unsigned int namelen;
name-hash.c- char name[FLEX_ARRAY];
name-hash.c-};
So, name-hash.c cannot include anything that includes dir.h.
next prev parent reply other threads:[~2023-06-03 2:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 18:45 [PATCH] statinfo.h: move DTYPE defines from dir.h Aleajndro R Sedeño
2023-06-02 18:50 ` Alejandro Sedeño
2023-06-02 19:06 ` Eric Sunshine
2023-06-02 19:21 ` Alejandro Sedeño
2023-06-02 19:27 ` Alejandro R Sedeño
2023-06-03 1:47 ` Elijah Newren
2023-06-03 1:56 ` Junio C Hamano
2023-06-03 2:04 ` Elijah Newren [this message]
2023-06-03 2:30 ` Junio C Hamano
2023-06-03 3:02 ` Alejandro Sedeño
2023-06-06 20:59 ` Alejandro R Sedeño
2023-06-12 18:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BHZ6a8VEuK=miMAcBG9RbUz+epuQ+d1xvwbRj_tsnYqcQ@mail.gmail.com' \
--to=newren@gmail.com \
--cc=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).