From: "Alejandro Sedeño" <asedeno@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: asedeno@mit.edu, git@vger.kernel.org, newren@gmail.com,
sunshine@sunshineco.com
Subject: Re: [PATCH] statinfo.h: move DTYPE defines from dir.h
Date: Fri, 2 Jun 2023 23:02:01 -0400 [thread overview]
Message-ID: <CALVMLfK4zD4ifgtQLfXBKFJH43hfLevmvVdsZ-ydKCt8kuPfqw@mail.gmail.com> (raw)
In-Reply-To: <xmqqilc571hf.fsf@gitster.g>
Sorry for the dupes; resending as plain-text as per list requirements.
On Fri, Jun 2, 2023 at 9:56 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Alejandro R Sedeño" <asedeno@google.com> writes:
>
> > …
> > Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> > Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
They are both me; it's my way of sticking with my historical personal
address and still attaching my work address for work reasons.
>
> This is a bit unusual; do you want to publish both names (I am
> assuming that they are the same single person)?
>
> I thought somebody in the earlier discussion identified the topic
> that was problematic by bisecting. It is a shame to lose that.
I identified it earlier, by inspection because the machine I build on
is slow and this was easy to track down.
> Perhaps it is a good idea to rephrase the beginning of the proposed
> commit log message to mention that, like
>
> 592fc5b3 (dir.h: move DTYPE defines from cache.h, 2023-04-22)
> moved DTYPE macros from cache.h to dir.h, but are still used
> by cache.h to implement ce_to_dtype(); but cache.h cannot
> include dir.h because ...
>
> or something?
Happy to rephrase.
-Alejandro
next prev parent reply other threads:[~2023-06-03 3:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 18:45 [PATCH] statinfo.h: move DTYPE defines from dir.h Aleajndro R Sedeño
2023-06-02 18:50 ` Alejandro Sedeño
2023-06-02 19:06 ` Eric Sunshine
2023-06-02 19:21 ` Alejandro Sedeño
2023-06-02 19:27 ` Alejandro R Sedeño
2023-06-03 1:47 ` Elijah Newren
2023-06-03 1:56 ` Junio C Hamano
2023-06-03 2:04 ` Elijah Newren
2023-06-03 2:30 ` Junio C Hamano
2023-06-03 3:02 ` Alejandro Sedeño [this message]
2023-06-06 20:59 ` Alejandro R Sedeño
2023-06-12 18:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALVMLfK4zD4ifgtQLfXBKFJH43hfLevmvVdsZ-ydKCt8kuPfqw@mail.gmail.com \
--to=asedeno@google.com \
--cc=asedeno@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).