From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: git@vger.kernel.org, Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH] Fix memory leak in get_reachable_subset
Date: Sat, 03 Jun 2023 11:02:56 +0900 [thread overview]
Message-ID: <xmqqedmt7167.fsf@gitster.g> (raw)
In-Reply-To: <20230603002819.1122129-1-mh@glandium.org> (Mike Hommey's message of "Sat, 3 Jun 2023 09:28:19 +0900")
Mike Hommey <mh@glandium.org> writes:
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
As most lines in the affected function seems to come from your
fcb2c076 (commit-reach: implement get_reachable_subset, 2018-11-02),
I'll redirect the review of this patch to you.
Thanks.
> commit-reach.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/commit-reach.c b/commit-reach.c
> index 70bde8af05..f15d84566b 100644
> --- a/commit-reach.c
> +++ b/commit-reach.c
> @@ -944,6 +944,8 @@ struct commit_list *get_reachable_subset(struct commit **from, int nr_from,
> }
> }
>
> + clear_prio_queue(&queue);
> +
> clear_commit_marks_many(nr_to, to, PARENT1);
> clear_commit_marks_many(nr_from, from, PARENT2);
next prev parent reply other threads:[~2023-06-03 2:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 0:28 [PATCH] Fix memory leak in get_reachable_subset Mike Hommey
2023-06-03 2:02 ` Junio C Hamano [this message]
2023-06-03 6:02 ` René Scharfe
2023-06-04 4:42 ` Junio C Hamano
2023-06-05 15:50 ` Derrick Stolee
-- strict thread matches above, loose matches on Subject: below --
2023-04-21 23:44 Mike Hommey
2023-04-24 15:21 ` Derrick Stolee
2023-04-24 16:09 ` Junio C Hamano
2023-04-24 20:41 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedmt7167.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).