From: Derrick Stolee <derrickstolee@github.com>
To: Mike Hommey <mh@glandium.org>, git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH] Fix memory leak in get_reachable_subset
Date: Mon, 24 Apr 2023 11:21:56 -0400 [thread overview]
Message-ID: <d2825134-61db-9da4-450c-f027117b3d48@github.com> (raw)
In-Reply-To: <20230421234409.1925489-1-mh@glandium.org>
On 4/21/2023 7:44 PM, Mike Hommey wrote:
> @@ -944,6 +944,8 @@ struct commit_list *get_reachable_subset(struct commit **from, int nr_from,
> }
> }
>
> + clear_prio_queue(&queue);
> +
Thanks. This is a leak that has existed since the method was first
created in fcb2c0769db (commit-reach: implement get_reachable_subset,
2018-11-02). I appreciate the attention to detail.
-Stolee
next prev parent reply other threads:[~2023-04-24 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 23:44 [PATCH] Fix memory leak in get_reachable_subset Mike Hommey
2023-04-24 15:21 ` Derrick Stolee [this message]
2023-04-24 16:09 ` Junio C Hamano
2023-04-24 20:41 ` Mike Hommey
-- strict thread matches above, loose matches on Subject: below --
2023-06-03 0:28 Mike Hommey
2023-06-03 2:02 ` Junio C Hamano
2023-06-03 6:02 ` René Scharfe
2023-06-04 4:42 ` Junio C Hamano
2023-06-05 15:50 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2825134-61db-9da4-450c-f027117b3d48@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).