From: Derrick Stolee <derrickstolee@github.com>
To: "Junio C Hamano" <gitster@pobox.com>, "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org, Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH] Fix memory leak in get_reachable_subset
Date: Mon, 5 Jun 2023 11:50:32 -0400 [thread overview]
Message-ID: <221ddd01-c058-dd87-9f3f-25146770f606@github.com> (raw)
In-Reply-To: <xmqq7csj6dok.fsf@gitster.g>
On 6/4/2023 12:42 AM, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>
>> Stolee reviewed it already when the patch was sent the first time, here:
>> https://lore.kernel.org/git/20230421234409.1925489-1-mh@glandium.org/T/#u
>
> OK. Thanks.
Thanks for finding this link. I saw this patch and immediately thought,
"I made this mistake a _second_ time?"
The patch continues to look good to me.
Thanks,
-Stolee
next prev parent reply other threads:[~2023-06-05 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 0:28 [PATCH] Fix memory leak in get_reachable_subset Mike Hommey
2023-06-03 2:02 ` Junio C Hamano
2023-06-03 6:02 ` René Scharfe
2023-06-04 4:42 ` Junio C Hamano
2023-06-05 15:50 ` Derrick Stolee [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-21 23:44 Mike Hommey
2023-04-24 15:21 ` Derrick Stolee
2023-04-24 16:09 ` Junio C Hamano
2023-04-24 20:41 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221ddd01-c058-dd87-9f3f-25146770f606@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).