From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <derrickstolee@github.com>
Cc: git@vger.kernel.org, Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH] Fix memory leak in get_reachable_subset
Date: Sat, 3 Jun 2023 08:02:51 +0200 [thread overview]
Message-ID: <21d3f105-ed32-e397-a1fe-53344894bd44@web.de> (raw)
In-Reply-To: <xmqqedmt7167.fsf@gitster.g>
Am 03.06.23 um 04:02 schrieb Junio C Hamano:
> Mike Hommey <mh@glandium.org> writes:
>
>> Signed-off-by: Mike Hommey <mh@glandium.org>
>> ---
>
> As most lines in the affected function seems to come from your
> fcb2c076 (commit-reach: implement get_reachable_subset, 2018-11-02),
> I'll redirect the review of this patch to you.
Stolee reviewed it already when the patch was sent the first time, here:
https://lore.kernel.org/git/20230421234409.1925489-1-mh@glandium.org/T/#u
>
> Thanks.
>
>> commit-reach.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/commit-reach.c b/commit-reach.c
>> index 70bde8af05..f15d84566b 100644
>> --- a/commit-reach.c
>> +++ b/commit-reach.c
>> @@ -944,6 +944,8 @@ struct commit_list *get_reachable_subset(struct commit **from, int nr_from,
>> }
>> }
>>
>> + clear_prio_queue(&queue);
Makes sense: The loop that dequeues would end before consuming all items
when all "to" commits are found to be reachable.
>> +
>> clear_commit_marks_many(nr_to, to, PARENT1);
>> clear_commit_marks_many(nr_from, from, PARENT2);
next prev parent reply other threads:[~2023-06-03 6:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 0:28 [PATCH] Fix memory leak in get_reachable_subset Mike Hommey
2023-06-03 2:02 ` Junio C Hamano
2023-06-03 6:02 ` René Scharfe [this message]
2023-06-04 4:42 ` Junio C Hamano
2023-06-05 15:50 ` Derrick Stolee
-- strict thread matches above, loose matches on Subject: below --
2023-04-21 23:44 Mike Hommey
2023-04-24 15:21 ` Derrick Stolee
2023-04-24 16:09 ` Junio C Hamano
2023-04-24 20:41 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d3f105-ed32-e397-a1fe-53344894bd44@web.de \
--to=l.s.r@web.de \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).