* [PATCH 1/2] over: re-sort Subject matches for WWW /T/ endpoint
@ 2024-01-01 0:57 Eric Wong
2024-01-01 0:57 ` [PATCH 2/2] view: always show strict|loose note w/ multi-roots Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2024-01-01 0:57 UTC (permalink / raw)
To: spew
When retrieving loose (Subject) matches for a thread, we wanted
the most recent matches in reverse chronological order.
However, when displaying the /T/ endpoint generating the thread
skeleton, we prefer ascending chronological order to match the
flow of the conversation.
Reported-by: Askar Safin <safinaskar@gmail.com>
Link: https://public-inbox.org/meta/CAPnZJGAqsh8ZhPaCAy5M2NZVNcWrr_Hr94t32VXiyiTXwD9jRQ@mail.gmail.com/
---
lib/PublicInbox/Over.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 61d01810..4279e21c 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -201,6 +201,11 @@ ORDER BY $sort_col DESC
# TODO separate strict and loose matches here once --reindex
# is fixed to preserve `tid' properly
push @$msgs, @$loose;
+
+ # we wanted to retrieve the latest loose messages; but preserve
+ # chronological ordering for threading /$INBOX/$MSGID/[tT]/
+ $sort_col eq 'ds' and
+ @$msgs = sort { $a->{ds} <=> $b->{ds} } @$msgs;
}
($nr, $msgs);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] view: always show strict|loose note w/ multi-roots
2024-01-01 0:57 [PATCH 1/2] over: re-sort Subject matches for WWW /T/ endpoint Eric Wong
@ 2024-01-01 0:57 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2024-01-01 0:57 UTC (permalink / raw)
To: spew
For thread skeletons with multiple roots, it makes sense to
note the strict|loose delineation even when the first message
matches the desired Message-ID.
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index b05a132b..b5047222 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -887,8 +887,8 @@ sub thread_results {
my $tip = splice(@$rootset, $idx, 1);
@$rootset = reverse @$rootset;
unshift @$rootset, $tip;
- $ctx->{sl_note} = strict_loose_note($nr);
}
+ $ctx->{sl_note} = strict_loose_note($nr);
}
$rootset
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-01 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-01 0:57 [PATCH 1/2] over: re-sort Subject matches for WWW /T/ endpoint Eric Wong
2024-01-01 0:57 ` [PATCH 2/2] view: always show strict|loose note w/ multi-roots Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).