From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id ACB801F451 for ; Mon, 1 Jan 2024 00:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1704070653; bh=HzmtFn5KImoy2RagQpTxWFmLOpoKfNhSb7u74dk7EQc=; h=From:To:Subject:Date:From; b=Dj0LFLDboMG+7cJedp7tfpZU8ov2SW2uD7dyzMXKmn1DZRoBmVhTDLI2MWuGaAZeL 36+hKIwkgpD2rWLKKG+HfGdX1s9rUkUUlmRushKbxkqHLR1fGD9/mw5+/je0wOS2kt wVv6+ArXtHhiR0zvFzqj6vPOKYBeizG+JinZjGyk= From: Eric Wong To: spew@80x24.org Subject: [PATCH 1/2] over: re-sort Subject matches for WWW /T/ endpoint Date: Mon, 1 Jan 2024 00:57:32 +0000 Message-ID: <20240101005733.3796173-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: When retrieving loose (Subject) matches for a thread, we wanted the most recent matches in reverse chronological order. However, when displaying the /T/ endpoint generating the thread skeleton, we prefer ascending chronological order to match the flow of the conversation. Reported-by: Askar Safin Link: https://public-inbox.org/meta/CAPnZJGAqsh8ZhPaCAy5M2NZVNcWrr_Hr94t32VXiyiTXwD9jRQ@mail.gmail.com/ --- lib/PublicInbox/Over.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm index 61d01810..4279e21c 100644 --- a/lib/PublicInbox/Over.pm +++ b/lib/PublicInbox/Over.pm @@ -201,6 +201,11 @@ ORDER BY $sort_col DESC # TODO separate strict and loose matches here once --reindex # is fixed to preserve `tid' properly push @$msgs, @$loose; + + # we wanted to retrieve the latest loose messages; but preserve + # chronological ordering for threading /$INBOX/$MSGID/[tT]/ + $sort_col eq 'ds' and + @$msgs = sort { $a->{ds} <=> $b->{ds} } @$msgs; } ($nr, $msgs); }