From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 1/2] over: re-sort Subject matches for WWW /T/ endpoint
Date: Mon, 1 Jan 2024 00:57:32 +0000 [thread overview]
Message-ID: <20240101005733.3796173-1-e@80x24.org> (raw)
When retrieving loose (Subject) matches for a thread, we wanted
the most recent matches in reverse chronological order.
However, when displaying the /T/ endpoint generating the thread
skeleton, we prefer ascending chronological order to match the
flow of the conversation.
Reported-by: Askar Safin <safinaskar@gmail.com>
Link: https://public-inbox.org/meta/CAPnZJGAqsh8ZhPaCAy5M2NZVNcWrr_Hr94t32VXiyiTXwD9jRQ@mail.gmail.com/
---
lib/PublicInbox/Over.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 61d01810..4279e21c 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -201,6 +201,11 @@ ORDER BY $sort_col DESC
# TODO separate strict and loose matches here once --reindex
# is fixed to preserve `tid' properly
push @$msgs, @$loose;
+
+ # we wanted to retrieve the latest loose messages; but preserve
+ # chronological ordering for threading /$INBOX/$MSGID/[tT]/
+ $sort_col eq 'ds' and
+ @$msgs = sort { $a->{ds} <=> $b->{ds} } @$msgs;
}
($nr, $msgs);
}
next reply other threads:[~2024-01-01 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 0:57 Eric Wong [this message]
2024-01-01 0:57 ` [PATCH 2/2] view: always show strict|loose note w/ multi-roots Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240101005733.3796173-1-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).