diff options
| author | Eric Wong <e@80x24.org> | 2023-11-30 11:40:57 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2023-11-30 21:36:51 +0000 |
| commit | afef2fd49bf7b29daa5039bd5875bf3a66fed187 (patch) | |
| tree | 1a3c68dc4515767bc83a0df3855e6f7a31354499 | |
| parent | c51cab322be0f255d8d51cea6c91a210fb35fb09 (diff) | |
| download | public-inbox-afef2fd49bf7b29daa5039bd5875bf3a66fed187.tar.gz | |
We only use it as a boolean flag, and there's no need to waste space for common, non-error cases.
| -rw-r--r-- | lib/PublicInbox/CodeSearchIdx.pm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/CodeSearchIdx.pm b/lib/PublicInbox/CodeSearchIdx.pm index bd67a57e..cf6a6efe 100644 --- a/lib/PublicInbox/CodeSearchIdx.pm +++ b/lib/PublicInbox/CodeSearchIdx.pm @@ -383,8 +383,8 @@ sub git_dir_hash ($) { hex(substr(sha256_hex($_[0]), 0, 8)) } sub _cb { # run_await cb my ($pid, $cmd, undef, $opt, $cb, $self, $git, @arg) = @_; return if $DO_QUIT; - ($git->{-cidx_err} = $?) ? warn("W: @$cmd (\$?=$?)\n") : - $cb->($opt, $self, $git, @arg); + $? ? ($git->{-cidx_err} = warn("W: @$cmd (\$?=$?)\n")) : + $cb->($opt, $self, $git, @arg); } sub run_git { |