about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2023-01-24 09:49:30 +0000
committerEric Wong <e@80x24.org>2023-01-24 10:07:28 +0000
commit686fb938a2a27beca406af6e8ab819aad608b06e (patch)
treec5698b9e9fd73fc23696a9e15beecbaa5fa7a517
parentfa5aad1d5f3c5abaa28a49181674930f2e06066e (diff)
downloadpublic-inbox-686fb938a2a27beca406af6e8ab819aad608b06e.tar.gz
git, cgit, or any other command failing isn't an error
we can do anything about in qspawn, so don't have Perl
emit line number info and needlessly pollute logs.
-rw-r--r--lib/PublicInbox/Qspawn.pm2
-rw-r--r--t/solver_git.t2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index cc81a4cd..5e4fd5cb 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -85,7 +85,7 @@ sub finalize ($) {
                 if (my $dst = $self->{qsp_err}) {
                         $$dst .= $$dst ? " $err" : "; $err";
                 }
-                warn "@{$self->{cmd}}: $err" if !$self->{-quiet};
+                warn "@{$self->{cmd}}: $err\n" if !$self->{-quiet};
         }
 
         my ($env, $qx_cb, $qx_arg, $qx_buf) =
diff --git a/t/solver_git.t b/t/solver_git.t
index 06d75816..122cf888 100644
--- a/t/solver_git.t
+++ b/t/solver_git.t
@@ -336,7 +336,7 @@ EOF
                         open $fh, '>', "$tmpdir/stderr.log" or xbail $!;
                         ok($s =~ s/^fatal: your current branch.*?\n//sm,
                                 'got current branch warning');
-                        ok($s =~ s/^.*? exit status=[1-9]+ .*?\n//sm,
+                        ok($s =~ s/^.*? exit status=[1-9]+\n\z//sm,
                                 'got exit status warning');
                         is($s, '', 'no unexpected warnings on empty coderepo');
                 }