olddoc user/dev discussion/patches/bugs/etc
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: olddoc-public@80x24.org
Subject: [PATCH] _tail: do not mutate existing arrays
Date: Fri, 29 Jul 2016 20:47:25 +0000	[thread overview]
Message-ID: <20160729204725.25447-1-e@80x24.org> (raw)

We need to ensure we have a consistent data structure across pages.
---
 lib/oldweb/_tail.rhtml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/oldweb/_tail.rhtml b/lib/oldweb/_tail.rhtml
index 4320fc2..14fc5a8 100644
--- a/lib/oldweb/_tail.rhtml
+++ b/lib/oldweb/_tail.rhtml
@@ -1,8 +1,8 @@
 <%
 public_email = @old_cfg['public_email']
 private_email = @old_cfg['private_email']
-source_code = Array(@old_cfg['source_code'])
-archive_urls = Array(@old_cfg['ml_url']).concat(Array(@old_cfg['nntp_url']))
+source_code = Array(@old_cfg['source_code']).dup
+archive_urls = Array(@old_cfg['ml_url']) + Array(@old_cfg['nntp_url'])
 if url = archive_urls.shift %><hr /><pre>
 mail archives: <a
 href="<%= url %>"><%= url %></a><%
@@ -20,11 +20,10 @@ href="mailto:<%= public_email %>"><%= public_email %></a><%
 href="mailto:<%= private_email %>"><%= private_email %></a><%
     end
   end
-end
 
 if url_or_cmd = source_code.shift
 %>
 source code: <%= url_or_cmd %>
 <% source_code.each do |x| %><%= "\t#{x}" %><% end
 end
-%></pre>
+%></pre><% end %>
-- 
EW


                 reply	other threads:[~2016-07-29 20:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://80x24.org/olddoc/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160729204725.25447-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=olddoc-public@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/olddoc.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).