From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	T_FILL_THIS_FORM_SHORT shortcircuit=no autolearn=ham autolearn_force=no
	version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 4A1311F955
	for <olddoc-public@80x24.org>; Fri, 29 Jul 2016 20:47:25 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: olddoc-public@80x24.org
Subject: [PATCH] _tail: do not mutate existing arrays
Date: Fri, 29 Jul 2016 20:47:25 +0000
Message-Id: <20160729204725.25447-1-e@80x24.org>
List-Id: <olddoc-public@80x24.org>

We need to ensure we have a consistent data structure across pages.
---
 lib/oldweb/_tail.rhtml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/oldweb/_tail.rhtml b/lib/oldweb/_tail.rhtml
index 4320fc2..14fc5a8 100644
--- a/lib/oldweb/_tail.rhtml
+++ b/lib/oldweb/_tail.rhtml
@@ -1,8 +1,8 @@
 <%
 public_email = @old_cfg['public_email']
 private_email = @old_cfg['private_email']
-source_code = Array(@old_cfg['source_code'])
-archive_urls = Array(@old_cfg['ml_url']).concat(Array(@old_cfg['nntp_url']))
+source_code = Array(@old_cfg['source_code']).dup
+archive_urls = Array(@old_cfg['ml_url']) + Array(@old_cfg['nntp_url'])
 if url = archive_urls.shift %><hr /><pre>
 mail archives: <a
 href="<%= url %>"><%= url %></a><%
@@ -20,11 +20,10 @@ href="mailto:<%= public_email %>"><%= public_email %></a><%
 href="mailto:<%= private_email %>"><%= private_email %></a><%
     end
   end
-end
 
 if url_or_cmd = source_code.shift
 %>
 source code: <%= url_or_cmd %>
 <% source_code.each do |x| %><%= "\t#{x}" %><% end
 end
-%></pre>
+%></pre><% end %>
-- 
EW