* [PATCH] _tail: do not mutate existing arrays
@ 2016-07-29 20:47 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-07-29 20:47 UTC (permalink / raw)
To: olddoc-public
We need to ensure we have a consistent data structure across pages.
---
lib/oldweb/_tail.rhtml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/oldweb/_tail.rhtml b/lib/oldweb/_tail.rhtml
index 4320fc2..14fc5a8 100644
--- a/lib/oldweb/_tail.rhtml
+++ b/lib/oldweb/_tail.rhtml
@@ -1,8 +1,8 @@
<%
public_email = @old_cfg['public_email']
private_email = @old_cfg['private_email']
-source_code = Array(@old_cfg['source_code'])
-archive_urls = Array(@old_cfg['ml_url']).concat(Array(@old_cfg['nntp_url']))
+source_code = Array(@old_cfg['source_code']).dup
+archive_urls = Array(@old_cfg['ml_url']) + Array(@old_cfg['nntp_url'])
if url = archive_urls.shift %><hr /><pre>
mail archives: <a
href="<%= url %>"><%= url %></a><%
@@ -20,11 +20,10 @@ href="mailto:<%= public_email %>"><%= public_email %></a><%
href="mailto:<%= private_email %>"><%= private_email %></a><%
end
end
-end
if url_or_cmd = source_code.shift
%>
source code: <%= url_or_cmd %>
<% source_code.each do |x| %><%= "\t#{x}" %><% end
end
-%></pre>
+%></pre><% end %>
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-29 20:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-29 20:47 [PATCH] _tail: do not mutate existing arrays Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/olddoc.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).