mwrap user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH] drop dlsym use for rb_stderr
@ 2023-01-08  5:20 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-01-08  5:20 UTC (permalink / raw)
  To: mwrap-public

A weak symbol works fine, here.
---
 ext/mwrap/mwrap.c      | 3 ++-
 ext/mwrap/mwrap_core.h | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index d88fee6..a45bb38 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -6,6 +6,7 @@
 #include "mwrap_core.h"
 
 static ID id_uminus;
+extern VALUE __attribute__((weak)) rb_stderr;
 extern VALUE __attribute__((weak)) rb_cObject;
 extern VALUE __attribute__((weak)) rb_eTypeError;
 extern VALUE __attribute__((weak)) rb_yield(VALUE);
@@ -33,7 +34,7 @@ static VALUE mwrap_dump(int argc, VALUE *argv, VALUE mod)
 
 	if (NIL_P(io))
 		/* library may be linked w/o Ruby */
-		io = *((VALUE *)dlsym(RTLD_DEFAULT, "rb_stderr"));
+		io = rb_stderr;
 
 	a.min = NIL_P(min) ? 0 : NUM2SIZET(min);
 	io = rb_io_get_io(io);
diff --git a/ext/mwrap/mwrap_core.h b/ext/mwrap/mwrap_core.h
index c0eea2f..721e5d3 100644
--- a/ext/mwrap/mwrap_core.h
+++ b/ext/mwrap/mwrap_core.h
@@ -26,7 +26,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <dlfcn.h>
 #include <assert.h>
 #include <errno.h>
 #include <sys/types.h>

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-08  5:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-08  5:20 [PATCH] drop dlsym use for rb_stderr Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).