From: Eric Wong <e@80x24.org>
To: mwrap-public@80x24.org
Subject: [PATCH] drop dlsym use for rb_stderr
Date: Sun, 8 Jan 2023 05:20:44 +0000 [thread overview]
Message-ID: <20230108052044.2493205-1-e@80x24.org> (raw)
A weak symbol works fine, here.
---
ext/mwrap/mwrap.c | 3 ++-
ext/mwrap/mwrap_core.h | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index d88fee6..a45bb38 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -6,6 +6,7 @@
#include "mwrap_core.h"
static ID id_uminus;
+extern VALUE __attribute__((weak)) rb_stderr;
extern VALUE __attribute__((weak)) rb_cObject;
extern VALUE __attribute__((weak)) rb_eTypeError;
extern VALUE __attribute__((weak)) rb_yield(VALUE);
@@ -33,7 +34,7 @@ static VALUE mwrap_dump(int argc, VALUE *argv, VALUE mod)
if (NIL_P(io))
/* library may be linked w/o Ruby */
- io = *((VALUE *)dlsym(RTLD_DEFAULT, "rb_stderr"));
+ io = rb_stderr;
a.min = NIL_P(min) ? 0 : NUM2SIZET(min);
io = rb_io_get_io(io);
diff --git a/ext/mwrap/mwrap_core.h b/ext/mwrap/mwrap_core.h
index c0eea2f..721e5d3 100644
--- a/ext/mwrap/mwrap_core.h
+++ b/ext/mwrap/mwrap_core.h
@@ -26,7 +26,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <dlfcn.h>
#include <assert.h>
#include <errno.h>
#include <sys/types.h>
reply other threads:[~2023-01-08 5:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108052044.2493205-1-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).