* [PATCH] location_name: fix uninitialized variable warnings
@ 2023-05-06 7:27 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-05-06 7:27 UTC (permalink / raw)
To: mwrap-perl
Apparently, the proper way to create an empty character strings is
still via newSVpvs(""), and not newSV(0) :x
---
Mwrap.xs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Mwrap.xs b/Mwrap.xs
index cbb7d15..e51259e 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -20,7 +20,7 @@ typedef struct src_loc * Devel__Mwrap__SrcLoc;
/* keep this consistent with httpd.h write_loc_name */
static SV *location_string(struct src_loc *l)
{
- SV *ret = newSV(0);
+ SV *ret = newSVpvs("");
if (l->f) {
sv_catpv(ret, l->f->fn);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-06 7:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-06 7:27 [PATCH] location_name: fix uninitialized variable warnings Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).