From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] location_name: fix uninitialized variable warnings
Date: Sat, 6 May 2023 07:27:58 +0000 [thread overview]
Message-ID: <20230506072758.4381-1-e@80x24.org> (raw)
Apparently, the proper way to create an empty character strings is
still via newSVpvs(""), and not newSV(0) :x
---
Mwrap.xs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Mwrap.xs b/Mwrap.xs
index cbb7d15..e51259e 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -20,7 +20,7 @@ typedef struct src_loc * Devel__Mwrap__SrcLoc;
/* keep this consistent with httpd.h write_loc_name */
static SV *location_string(struct src_loc *l)
{
- SV *ret = newSV(0);
+ SV *ret = newSVpvs("");
if (l->f) {
sv_catpv(ret, l->f->fn);
reply other threads:[~2023-05-06 7:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230506072758.4381-1-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).