mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 7/7] t/mwrap: don't dump unless we check the output
Date: Sat,  2 Nov 2019 02:03:31 +0000	[thread overview]
Message-ID: <20191102020331.28050-8-e@80x24.org> (raw)
In-Reply-To: <20191102020331.28050-1-e@80x24.org>

No point in putting data into the FS cache that we won't read.
---
 t/mwrap.t | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/t/mwrap.t b/t/mwrap.t
index 3dd3d57..8806847 100644
--- a/t/mwrap.t
+++ b/t/mwrap.t
@@ -18,6 +18,7 @@ my $src = slurp('blib/script/mwrap-perl');
 	mwrap_run('dump test', $env, '-e', '$x = "hello world" x '.$nr);
 	ok(-s $dump, "dump file written to");
 	my $s = slurp($dump);
+	truncate($dump, 0);
 	my $re = qr/([0-9]+)[ \t]+([0-9]+)[ \t]+-e:1[ \t]*\n/sm;
 	my ($bytes, $n);
 	if ($s =~ $re) {
@@ -34,18 +35,13 @@ SKIP: { # C++ program which uses malloc via "new"
 	my $exp = `cmake -h`;
 	skip 'cmake missing', 2 if $?;
 	skip "`cmake -h' gave no output", 2 unless $exp =~ /\S/s;
-	open my $truncate, '>', $dump or die;
-	close $truncate or die;
-	my $env = { MWRAP => "dump_path:$dump" };
-	mwrap_run('cmake (C++ new)', $env, '-e',
-		'system(qw(cmake -h)); exit $?');
+	mwrap_run('cmake (C++ new)', {}, '-e', 'system(qw(cmake -h)); exit $?');
 	my $res = slurp($out);
 	is($res, $exp, "`cmake -h' works");
 };
 
 {
-	my $env = { MWRAP => "dump_path:$dump" };
-	mwrap_run('total_bytes*', $env, '-e', <<'E1');
+	mwrap_run('total_bytes*', {}, '-e', <<'E1');
 my $A = Devel::Mwrap::total_bytes_allocated();
 my $f = Devel::Mwrap::total_bytes_freed();
 print("$A - $f\n");
@@ -55,9 +51,8 @@ E1
 }
 
 {
-	my $env = { MWRAP => "dump_path:$dump" };
-	mwrap_run('source location', $env, 't/source_location.perl');
-	mwrap_run('source location via -d:', $env,
+	mwrap_run('source location', {}, 't/source_location.perl');
+	mwrap_run('source location via -d:', {},
 		'-d:Mwrap', 't/source_location.perl');
 }
 

      parent reply	other threads:[~2019-11-02  2:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  2:03 [PATCH 0/7] updates while I learn XS and perlapi Eric Wong
2019-11-02  2:03 ` [PATCH 1/7] allow using "-d:Mwrap" from the command-line Eric Wong
2019-11-02  2:03 ` [PATCH 2/7] use ppport.h for caller_cx with older Perl versions Eric Wong
2019-11-02  2:03 ` [PATCH 3/7] memalign: perform rcu_read_unlock on ENOMEM Eric Wong
2019-11-02  2:03 ` [PATCH 4/7] update_stats_rcu_lock: favor PL_curcop instead of caller_cx Eric Wong
2019-11-02  2:03 ` [PATCH 5/7] script/mwrap-perl: more portable Mwrap.so detection Eric Wong
2019-11-02  2:03 ` [PATCH 6/7] support Devel::Mwrap::each with callback Eric Wong
2019-11-02  2:03 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102020331.28050-8-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).