mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 4/7] update_stats_rcu_lock: favor PL_curcop instead of caller_cx
Date: Sat,  2 Nov 2019 02:03:28 +0000	[thread overview]
Message-ID: <20191102020331.28050-5-e@80x24.org> (raw)
In-Reply-To: <20191102020331.28050-1-e@80x24.org>

PL_curcop seems to actually work correctly for resolving the
current op, rather than walking up the stack.
---
 Mwrap.xs | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/Mwrap.xs b/Mwrap.xs
index 92fc4de..a89578a 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -4,7 +4,6 @@
  * Disclaimer: I don't really know my way around XS or Perl internals well
  */
 #define _LGPL_SOURCE /* allows URCU to inline some stuff */
-#define NEED_caller_cx
 #include "EXTERN.h"
 #include "perl.h"
 #include "XSUB.h"
@@ -295,33 +294,28 @@ static void update_stats_rcu_unlock(const struct src_loc *l)
 
 static struct src_loc *update_stats_rcu_lock(size_t size, uintptr_t caller)
 {
-	const PERL_CONTEXT *cx = NULL;
 	static const size_t xlen = sizeof(caller);
 	struct src_loc *k, *ret = 0;
 	char *dst;
+	const COP *cop;
 
 	if (caa_unlikely(!totals)) return 0;
 	if (locating++) goto out; /* do not recurse into another *alloc */
 
 	uatomic_add(&total_bytes_inc, size);
+	cop = PL_curcop;
 
 	rcu_read_lock();
-	cx = caller_cx(0, NULL);
-	if (cx) {
-		const char *ptr = OutCopFILE(cx->blk_oldcop);
-		const COP *lcop;
+	if (cop) {
+		const char *ptr = OutCopFILE(cop);
 		unsigned line;
 		size_t len;
 		size_t int_size = INT2STR_MAX;
 
-		if (!ptr) goto unknown;
+		if (!ptr)
+			goto unknown;
 
-		lcop = Perl_closest_cop(aTHX_ cx->blk_oldcop,
-					OpSIBLING(cx->blk_oldcop),
-					cx->blk_sub.retop, TRUE);
-		if (!lcop)
-			lcop = cx->blk_oldcop;
-		line = CopLINE(lcop);
+		line = CopLINE(cop);
 
 		/* avoid vsnprintf or anything which could call malloc here: */
 		len = strlen(ptr);

  parent reply	other threads:[~2019-11-02  2:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  2:03 [PATCH 0/7] updates while I learn XS and perlapi Eric Wong
2019-11-02  2:03 ` [PATCH 1/7] allow using "-d:Mwrap" from the command-line Eric Wong
2019-11-02  2:03 ` [PATCH 2/7] use ppport.h for caller_cx with older Perl versions Eric Wong
2019-11-02  2:03 ` [PATCH 3/7] memalign: perform rcu_read_unlock on ENOMEM Eric Wong
2019-11-02  2:03 ` Eric Wong [this message]
2019-11-02  2:03 ` [PATCH 5/7] script/mwrap-perl: more portable Mwrap.so detection Eric Wong
2019-11-02  2:03 ` [PATCH 6/7] support Devel::Mwrap::each with callback Eric Wong
2019-11-02  2:03 ` [PATCH 7/7] t/mwrap: don't dump unless we check the output Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102020331.28050-5-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).