From: Michael Tokarev <mjt@tls.msk.ru>
To: Tanmay <tanmaynpatil105@gmail.com>,
qemu-stable@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Fixes: Indentation using TABs and improve formatting
Date: Sat, 4 May 2024 23:34:59 +0300 [thread overview]
Message-ID: <df14595f-3a26-4b7f-948d-df522f487b92@tls.msk.ru> (raw)
In-Reply-To: <CAHnsOnM6gzcjpmEqCN0cFjZKXZCK_ZGAphuf46xWmUyBcNrAxQ@mail.gmail.com>
04.05.2024 21:58, Tanmay wrote:
> Hi,
>
> I have attached a patch file that fixes indentation and formatting for some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373
> <https://gitlab.com/qemu-project/qemu/-/issues/373>.
it is sort of good you posted this patch to stable@. It has absolutely nothing to do
with stable, but it serves as a an example of things which should - in my opinion -
not be done at all. We had another similar change, 55339361276a "sh4: Coding style:
Remove tabs", which makes all further changes (fixes) in this area basically
non-back-portable to previous stable series.
FWIW,
/mjt
--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
next parent reply other threads:[~2024-05-04 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHnsOnM6gzcjpmEqCN0cFjZKXZCK_ZGAphuf46xWmUyBcNrAxQ@mail.gmail.com>
2024-05-04 20:34 ` Michael Tokarev [this message]
2024-05-05 6:05 ` [PATCH] Fixes: Indentation using TABs and improve formatting Tanmay
2024-05-06 4:41 ` Thomas Huth
2024-05-06 6:14 ` Tanmay
[not found] <CAHnsOnN6AkE3visU9jaycp61G87XRJFwDGx4D1=HJSJpA2tfXw@mail.gmail.com>
2024-05-07 10:26 ` Peter Maydell
2024-05-08 8:19 ` Tanmay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df14595f-3a26-4b7f-948d-df522f487b92@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=tanmaynpatil105@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).