From: Tanmay <tanmaynpatil105@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
qemu-stable@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] Fixes: Indentation using TABs and improve formatting
Date: Mon, 6 May 2024 11:44:07 +0530 [thread overview]
Message-ID: <CAHnsOnP8bV+e6wfB02rmO583g3qSgW=O0FadUu2R71e3BMm4rA@mail.gmail.com> (raw)
In-Reply-To: <b655fa90-d9a8-475b-ac65-27bf12a48916@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]
Sure, I'll do it!
Thanks,
Tanmay
On Mon, 6 May 2024 at 10:11, Thomas Huth <thuth@redhat.com> wrote:
> On 04/05/2024 22.34, Michael Tokarev wrote:
> > 04.05.2024 21:58, Tanmay wrote:
> >> Hi,
> >>
> >> I have attached a patch file that fixes indentation and formatting for
> >> some files as listed in
> https://gitlab.com/qemu-project/qemu/-/issues/373
> >> <https://gitlab.com/qemu-project/qemu/-/issues/373>.
> >
> > it is sort of good you posted this patch to stable@. It has absolutely
> > nothing to do
> > with stable, but it serves as a an example of things which should - in
> my
> > opinion -
> > not be done at all.
>
> I disagree. Yes, clean-up patches like this make it somewhat difficult to
> backport other patches to stable, but that should not be the reason to not
> do cleanups at all. If we keep badly formatted code in the repository,
> people will copy-n-paste it to other places, or if you have to do fixes in
> sources that have mixed TABs and spaces, you often get complaints from
> checkpatch.pl though it is not your fault. So we should get this straight
> at
> one point in time.
>
> So, Tanmay, could you please resend your patch, this time to
> qemu-devel@nongnu.org instead of qemu-stable, and CC: qemu-arm@nongnu.org
> and the corresponding ARM maintainers (you can use
> scripts/get_maintainers.pl to find out the correct maintainers that
> should
> be CC:-ed). And if possible, please send your patch inline and not as an
> attachment (so it's possible to comment on the patch via hitting the reply
> button), preferably with "git send-email" instead of using your e-mail
> program.
>
> Thanks!
> Thomas
>
>
[-- Attachment #2: Type: text/html, Size: 2598 bytes --]
next prev parent reply other threads:[~2024-05-06 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHnsOnM6gzcjpmEqCN0cFjZKXZCK_ZGAphuf46xWmUyBcNrAxQ@mail.gmail.com>
2024-05-04 20:34 ` [PATCH] Fixes: Indentation using TABs and improve formatting Michael Tokarev
2024-05-05 6:05 ` Tanmay
2024-05-06 4:41 ` Thomas Huth
2024-05-06 6:14 ` Tanmay [this message]
[not found] <CAHnsOnN6AkE3visU9jaycp61G87XRJFwDGx4D1=HJSJpA2tfXw@mail.gmail.com>
2024-05-07 10:26 ` Peter Maydell
2024-05-08 8:19 ` Tanmay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHnsOnP8bV+e6wfB02rmO583g3qSgW=O0FadUu2R71e3BMm4rA@mail.gmail.com' \
--to=tanmaynpatil105@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).