From: Peter Maydell <peter.maydell@linaro.org>
To: Tanmay <tanmaynpatil105@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm@nongnu.org,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
pbonzini@redhat.com, richard.henderson@linaro.org
Subject: Re: [PATCH] Fixes: Indentation using TABs and improve formatting
Date: Tue, 7 May 2024 11:26:15 +0100 [thread overview]
Message-ID: <CAFEAcA8S1HJgcJdC5M=V1UHZHwNKhX_ii9PNNc88uC2Gi2E3sw@mail.gmail.com> (raw)
In-Reply-To: <CAHnsOnN6AkE3visU9jaycp61G87XRJFwDGx4D1=HJSJpA2tfXw@mail.gmail.com>
On Mon, 6 May 2024 at 07:20, Tanmay <tanmaynpatil105@gmail.com> wrote:
>
> Hi,
>
> I have added a patch inline that fixes indentation and formatting for some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373.
>
> Thanks,
> Tanmay
Hi; thanks for this patch. Unfortunately there seem to be some
problems with the formatting, which mean it doesn't apply correctly.
In particular you've sent it as a plain/text + HTML email, and
something (probably your mail client) is wrapping long lines.
I can usually fix something like this up on my end for a first
time submitter, but in this case the patch is just way too big
for that to be practical.
I generally don't recommend trying to send patch emails directly
through the gmail web UI -- it unfortunately mangles them too
much. Personally I use git-send-email; it is a bit awkward to
set up, but https://git-send-email.io/ has a nice step-by-step
guide including specific details on how to configure it to send
via Gmail.
> From 46026574821c46804111eea6607a1b39314b7abe Mon Sep 17 00:00:00 2001
> From: Tanmay Patil <tanmaynpatil105@gmail.com>
> Date: Sat, 25 Nov 2023 00:53:54 +0530
> Subject: [PATCH] Fixes: Indentation using TABs and improve formatting
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/373
>
> Files changed:
> - hw/arm/boot.c
> - hw/char/omap_uart.c
> - hw/dma/pxa2xx_dma.c
> - hw/gpio/omap_gpio.c
> - hw/gpio/zaurus.c
> - hw/input/tsc2005.c
> - hw/input/tsc210x.c
> - hw/intc/omap_intc.c
> - hw/misc/cbus.c
> - hw/misc/omap_clk.c
> - hw/misc/omap_l4.c
> - hw/misc/omap_sdrc.c
> - hw/misc/omap_tap.c
> - hw/sd/omap_mmc.c
> - hw/sd/pxa2xx_mmci.c
> - hw/timer/omap_gptimer.c
> - hw/timer/omap_synctimer.c
> - hw/timer/pxa2xx_timer.c
> - include/hw/arm/pxa.h
> - include/hw/arm/sharpsl.h
> - include/hw/arm/soc_dma.h
> - tcg/arm/tcg-target.h
>
> Signed-off-by: Tanmay Patil <tanmaynpatil105@gmail.com>
> ---
> hw/arm/boot.c | 8 +-
> hw/char/omap_uart.c | 49 +-
> hw/dma/pxa2xx_dma.c | 198 ++++----
> hw/gpio/omap_gpio.c | 243 +++++-----
> hw/gpio/zaurus.c | 61 +--
> hw/input/tsc2005.c | 130 ++---
> hw/input/tsc210x.c | 442 +++++++++--------
> hw/intc/omap_intc.c | 261 +++++-----
> hw/misc/cbus.c | 202 ++++----
> hw/misc/omap_clk.c | 999 +++++++++++++++++++-------------------
> hw/misc/omap_l4.c | 21 +-
> hw/misc/omap_sdrc.c | 135 +++---
> hw/misc/omap_tap.c | 28 +-
> hw/sd/omap_mmc.c | 208 ++++----
> hw/sd/pxa2xx_mmci.c | 149 +++---
> hw/timer/omap_gptimer.c | 126 ++---
> hw/timer/omap_synctimer.c | 7 +-
> hw/timer/pxa2xx_timer.c | 279 ++++++-----
> include/hw/arm/pxa.h | 100 ++--
> include/hw/arm/sharpsl.h | 2 +-
> include/hw/arm/soc_dma.h | 4 +-
> tcg/arm/tcg-target.h | 4 +-
> 22 files changed, 1903 insertions(+), 1753 deletions(-)
This is a lot of changes to do all in one commit, even though they're
all just whitespace fixes. Could you split them up, please, into
multiple patches that tackle fewer files at a time?
thanks
-- PMM
next parent reply other threads:[~2024-05-07 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHnsOnN6AkE3visU9jaycp61G87XRJFwDGx4D1=HJSJpA2tfXw@mail.gmail.com>
2024-05-07 10:26 ` Peter Maydell [this message]
2024-05-08 8:19 ` [PATCH] Fixes: Indentation using TABs and improve formatting Tanmay
[not found] <CAHnsOnM6gzcjpmEqCN0cFjZKXZCK_ZGAphuf46xWmUyBcNrAxQ@mail.gmail.com>
2024-05-04 20:34 ` Michael Tokarev
2024-05-05 6:05 ` Tanmay
2024-05-06 4:41 ` Thomas Huth
2024-05-06 6:14 ` Tanmay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8S1HJgcJdC5M=V1UHZHwNKhX_ii9PNNc88uC2Gi2E3sw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tanmaynpatil105@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).