From: BALATON Zoltan <balaton@eik.bme.hu>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Zhao Liu <zhao1.liu@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, John Snow <jsnow@redhat.com>,
qemu-ppc@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Richard Henderson <richard.henderson@linaro.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v3 06/11] hw/misc/macio: Realize IDE controller before accessing it
Date: Thu, 8 Feb 2024 19:33:18 +0100 (CET) [thread overview]
Message-ID: <4f25c957-3019-2dcf-56ac-cf34a2fb6c53@eik.bme.hu> (raw)
In-Reply-To: <20240208181245.96617-7-philmd@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]
On Thu, 8 Feb 2024, Philippe Mathieu-Daudé wrote:
> We should not wire IRQs on unrealized device.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/misc/macio/macio.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c
> index c9f22f8515..db662a2065 100644
> --- a/hw/misc/macio/macio.c
> +++ b/hw/misc/macio/macio.c
> @@ -122,15 +122,17 @@ static bool macio_realize_ide(MacIOState *s, MACIOIDEState *ide,
> Error **errp)
> {
> SysBusDevice *sbd = SYS_BUS_DEVICE(ide);
> + bool success;
>
> - sysbus_connect_irq(sbd, 0, irq0);
> - sysbus_connect_irq(sbd, 1, irq1);
> qdev_prop_set_uint32(DEVICE(ide), "channel", dmaid);
> object_property_set_link(OBJECT(ide), "dbdma", OBJECT(&s->dbdma),
> &error_abort);
> macio_ide_register_dma(ide);
> + success = qdev_realize(DEVICE(ide), BUS(&s->macio_bus), errp);
If realize is unsuccessful can you connect irqs if device may be
unrealized? So maybe either the next two lines should be in an if block or
drop the success flag and return false here if (!qdev_realize) and true at
end of func?
Regards,
BALATON Zoltan
> + sysbus_connect_irq(sbd, 0, irq0);
> + sysbus_connect_irq(sbd, 1, irq1);
>
> - return qdev_realize(DEVICE(ide), BUS(&s->macio_bus), errp);
> + return success;
> }
>
> static void macio_oldworld_realize(PCIDevice *d, Error **errp)
>
next prev parent reply other threads:[~2024-02-08 18:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 18:12 [PATCH v3 00/11] hw: Strengthen SysBus & QBus API Philippe Mathieu-Daudé
2024-02-08 18:12 ` [PATCH v3 01/11] hw/ide/ich9: Use AHCIPCIState typedef Philippe Mathieu-Daudé
2024-02-09 11:28 ` Peter Maydell
2024-02-08 18:12 ` [PATCH v3 02/11] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' Philippe Mathieu-Daudé
2024-02-09 11:28 ` Peter Maydell
2024-02-12 11:24 ` Yoshinori Sato
2024-02-08 18:12 ` [PATCH v3 03/11] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary Philippe Mathieu-Daudé
2024-02-09 11:29 ` Peter Maydell
2024-02-12 11:25 ` Yoshinori Sato
2024-02-08 18:12 ` [PATCH v3 04/11] hw/i386/pc_q35: Realize LPC PCI function before accessing it Philippe Mathieu-Daudé
2024-02-08 18:29 ` BALATON Zoltan
2024-02-08 18:12 ` [PATCH v3 05/11] hw/ppc/prep: Realize ISA bridge " Philippe Mathieu-Daudé
2024-02-09 11:29 ` Peter Maydell
2024-02-09 21:29 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 06/11] hw/misc/macio: Realize IDE controller " Philippe Mathieu-Daudé
2024-02-08 18:33 ` BALATON Zoltan [this message]
2024-02-09 6:40 ` Philippe Mathieu-Daudé
2024-02-09 21:32 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 07/11] hw/sh4/r2d: " Philippe Mathieu-Daudé
2024-02-09 11:30 ` Peter Maydell
2024-02-12 12:48 ` Yoshinori Sato
2024-05-03 21:34 ` Guenter Roeck
2024-02-08 18:12 ` [PATCH v3 08/11] hw/sparc/sun4m: Realize DMA " Philippe Mathieu-Daudé
2024-02-09 11:37 ` Peter Maydell
2024-02-09 22:37 ` Mark Cave-Ayland
2024-02-09 21:38 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 09/11] hw/sparc/leon3: Realize GRLIB IRQ " Philippe Mathieu-Daudé
2024-02-09 11:38 ` Peter Maydell
2024-02-09 21:39 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 10/11] hw/sparc/leon3: Initialize GPIO before realizing CPU devices Philippe Mathieu-Daudé
2024-02-09 11:35 ` Peter Maydell
2024-02-09 21:48 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 11/11] hw/sparc64/cpu: " Philippe Mathieu-Daudé
2024-02-09 11:34 ` Peter Maydell
2024-02-09 22:01 ` Mark Cave-Ayland
2024-02-13 13:00 ` Philippe Mathieu-Daudé
2024-02-09 21:49 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f25c957-3019-2dcf-56ac-cf34a2fb6c53@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhao1.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).