From: Guenter Roeck <linux@roeck-us.net>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Zhao Liu <zhao1.liu@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, John Snow <jsnow@redhat.com>,
qemu-ppc@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Richard Henderson <richard.henderson@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH v3 07/11] hw/sh4/r2d: Realize IDE controller before accessing it
Date: Fri, 3 May 2024 14:34:24 -0700 [thread overview]
Message-ID: <3434b32e-036a-485c-b3c2-3dd111e6152d@roeck-us.net> (raw)
In-Reply-To: <20240208181245.96617-8-philmd@linaro.org>
Hi,
On Thu, Feb 08, 2024 at 07:12:40PM +0100, Philippe Mathieu-Daudé wrote:
> We should not wire IRQs on unrealized device.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
qemu 9.0 fails to boot Linux from ide/ata drives with the sh4
and sh4eb emulations. Error log is as follows.
ata1.00: ATA-7: QEMU HARDDISK, 2.5+, max UDMA/100
ata1.00: 16384 sectors, multi 16: LBA48
ata1.00: configured for PIO
scsi 0:0:0:0: Direct-Access ATA QEMU HARDDISK 2.5+ PQ: 0 ANSI: 5
sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
sd 0:0:0:0: [sda] Write Protect is off
sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
ata1: lost interrupt (Status 0x58)
[ and more similar errors ]
qemu command line:
qemu-system-sh4eb -M r2d -kernel arch/sh/boot/zImage \
-snapshot -drive file=rootfs.ext2,format=raw,if=ide \
-append "root=/dev/sda console=ttySC1,115200 noiotrap" \
-serial null -serial stdio -monitor null -nographic -no-reboot
Bisect points to this patch (see below). Reverting it fixes the problem.
Guenter
---
bisect log:
# bad: [c25df57ae8f9fe1c72eee2dab37d76d904ac382e] Update version for 9.0.0 release
# good: [1600b9f46b1bd08b00fe86c46ef6dbb48cbe10d6] Update version for v8.2.0 release
git bisect start 'v9.0.0' 'v8.2.0'
# good: [62357c047a5abc6ede992159ed7c0aaaeb50617a] Merge tag 'qemu-sparc-20240213' of https://github.com/mcayland/qemu into staging
git bisect good 62357c047a5abc6ede992159ed7c0aaaeb50617a
# bad: [d65f1ed7de1559534d0a1fabca5bdd81c594c7ca] docs/acpi/bits: add some clarity and details while also improving formating
git bisect bad d65f1ed7de1559534d0a1fabca5bdd81c594c7ca
# bad: [99e1c1137b6f339be1e4b76e243ad7b7c3d3cb8c] hw/i386/pc: Populate RTC attribute directly
git bisect bad 99e1c1137b6f339be1e4b76e243ad7b7c3d3cb8c
# bad: [760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0] Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
git bisect bad 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0
# good: [f2b4a98930c122648e9dc494e49cea5dffbcc2be] target/arm: Allow access to SPSR_hyp from hyp mode
git bisect good f2b4a98930c122648e9dc494e49cea5dffbcc2be
# bad: [1a8e2f58c5dd721086284f827326b370d19ad9eb] hw/i386/q35: Use DEVICE() cast macro with PCIDevice object
git bisect bad 1a8e2f58c5dd721086284f827326b370d19ad9eb
# good: [59ae6bcddc3651b55b96c2bf05a6cd4312e46d10] hw/ppc/prep: Realize ISA bridge before accessing it
git bisect good 59ae6bcddc3651b55b96c2bf05a6cd4312e46d10
# bad: [7ed9a5f626a6c932a8c869a91e6a8b3e2029f5ef] hw/intc/grlib_irqmp: implements the multiprocessor status register
git bisect bad 7ed9a5f626a6c932a8c869a91e6a8b3e2029f5ef
# bad: [d08b7af3f7f27f6f3da8446756bf0b9352026b1d] target/sparc: Provide hint about CPUSPARCState::irq_manager member
git bisect bad d08b7af3f7f27f6f3da8446756bf0b9352026b1d
# bad: [5e37bc4997c32a1c9a6621a060462c84df9f1b8f] hw/dma: Pass parent object to i8257_dma_init()
git bisect bad 5e37bc4997c32a1c9a6621a060462c84df9f1b8f
# bad: [3c5f86a22686ef475a8259c0d8ee714f61c770c9] hw/sh4/r2d: Realize IDE controller before accessing it
git bisect bad 3c5f86a22686ef475a8259c0d8ee714f61c770c9
# good: [fc432ba0f58343c8912b80e9056315bb9bd8df92] hw/misc/macio: Realize IDE controller before accessing it
git bisect good fc432ba0f58343c8912b80e9056315bb9bd8df92
# first bad commit: [3c5f86a22686ef475a8259c0d8ee714f61c770c9] hw/sh4/r2d: Realize IDE controller before accessing it
next prev parent reply other threads:[~2024-05-03 21:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 18:12 [PATCH v3 00/11] hw: Strengthen SysBus & QBus API Philippe Mathieu-Daudé
2024-02-08 18:12 ` [PATCH v3 01/11] hw/ide/ich9: Use AHCIPCIState typedef Philippe Mathieu-Daudé
2024-02-09 11:28 ` Peter Maydell
2024-02-08 18:12 ` [PATCH v3 02/11] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' Philippe Mathieu-Daudé
2024-02-09 11:28 ` Peter Maydell
2024-02-12 11:24 ` Yoshinori Sato
2024-02-08 18:12 ` [PATCH v3 03/11] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary Philippe Mathieu-Daudé
2024-02-09 11:29 ` Peter Maydell
2024-02-12 11:25 ` Yoshinori Sato
2024-02-08 18:12 ` [PATCH v3 04/11] hw/i386/pc_q35: Realize LPC PCI function before accessing it Philippe Mathieu-Daudé
2024-02-08 18:29 ` BALATON Zoltan
2024-02-08 18:12 ` [PATCH v3 05/11] hw/ppc/prep: Realize ISA bridge " Philippe Mathieu-Daudé
2024-02-09 11:29 ` Peter Maydell
2024-02-09 21:29 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 06/11] hw/misc/macio: Realize IDE controller " Philippe Mathieu-Daudé
2024-02-08 18:33 ` BALATON Zoltan
2024-02-09 6:40 ` Philippe Mathieu-Daudé
2024-02-09 21:32 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 07/11] hw/sh4/r2d: " Philippe Mathieu-Daudé
2024-02-09 11:30 ` Peter Maydell
2024-02-12 12:48 ` Yoshinori Sato
2024-05-03 21:34 ` Guenter Roeck [this message]
2024-02-08 18:12 ` [PATCH v3 08/11] hw/sparc/sun4m: Realize DMA " Philippe Mathieu-Daudé
2024-02-09 11:37 ` Peter Maydell
2024-02-09 22:37 ` Mark Cave-Ayland
2024-02-09 21:38 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 09/11] hw/sparc/leon3: Realize GRLIB IRQ " Philippe Mathieu-Daudé
2024-02-09 11:38 ` Peter Maydell
2024-02-09 21:39 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 10/11] hw/sparc/leon3: Initialize GPIO before realizing CPU devices Philippe Mathieu-Daudé
2024-02-09 11:35 ` Peter Maydell
2024-02-09 21:48 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 11/11] hw/sparc64/cpu: " Philippe Mathieu-Daudé
2024-02-09 11:34 ` Peter Maydell
2024-02-09 22:01 ` Mark Cave-Ayland
2024-02-13 13:00 ` Philippe Mathieu-Daudé
2024-02-09 21:49 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3434b32e-036a-485c-b3c2-3dd111e6152d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
--cc=zhao1.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).