From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Zhao Liu <zhao1.liu@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, John Snow <jsnow@redhat.com>,
qemu-ppc@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Richard Henderson <richard.henderson@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Fabien Chouteau <chouteau@adacore.com>,
Frederic Konrad <konrad.frederic@yahoo.fr>,
Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [PATCH v3 10/11] hw/sparc/leon3: Initialize GPIO before realizing CPU devices
Date: Fri, 9 Feb 2024 21:48:41 +0000 [thread overview]
Message-ID: <075417ae-151f-46d2-a59b-db36aa20418f@ilande.co.uk> (raw)
In-Reply-To: <20240208181245.96617-11-philmd@linaro.org>
On 08/02/2024 18:12, Philippe Mathieu-Daudé wrote:
> Inline cpu_create() in order to call
> qdev_init_gpio_in_named_with_opaque()
> before the CPU is realized.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/sparc/leon3.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
> index 0df5fc949d..0e1d749306 100644
> --- a/hw/sparc/leon3.c
> +++ b/hw/sparc/leon3.c
> @@ -234,8 +234,11 @@ static void leon3_generic_hw_init(MachineState *machine)
> APBPnp *apb_pnp;
>
> /* Init CPU */
> - cpu = SPARC_CPU(cpu_create(machine->cpu_type));
> + cpu = SPARC_CPU(object_new(machine->cpu_type));
> env = &cpu->env;
> + qdev_init_gpio_in_named_with_opaque(DEVICE(cpu), leon3_set_pil_in,
> + env, "pil", 1);
> + qdev_realize(DEVICE(cpu), NULL, &error_fatal);
I know it's not part of this patch, but I think that
qdev_init_gpio_in_named_with_opaque() can be replaced with just
qdev_init_gpio_in_named(), and leon3_set_pil_in() updated to take CPUState.
> cpu_sparc_set_id(env, 0);
>
> @@ -261,8 +264,6 @@ static void leon3_generic_hw_init(MachineState *machine)
>
> /* Allocate IRQ manager */
> irqmpdev = qdev_new(TYPE_GRLIB_IRQMP);
> - qdev_init_gpio_in_named_with_opaque(DEVICE(cpu), leon3_set_pil_in,
> - env, "pil", 1);
> sysbus_realize_and_unref(SYS_BUS_DEVICE(irqmpdev), &error_fatal);
> sysbus_mmio_map(SYS_BUS_DEVICE(irqmpdev), 0, LEON3_IRQMP_OFFSET);
> qdev_connect_gpio_out_named(irqmpdev, "grlib-irq", 0,
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
next prev parent reply other threads:[~2024-02-09 21:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 18:12 [PATCH v3 00/11] hw: Strengthen SysBus & QBus API Philippe Mathieu-Daudé
2024-02-08 18:12 ` [PATCH v3 01/11] hw/ide/ich9: Use AHCIPCIState typedef Philippe Mathieu-Daudé
2024-02-09 11:28 ` Peter Maydell
2024-02-08 18:12 ` [PATCH v3 02/11] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' Philippe Mathieu-Daudé
2024-02-09 11:28 ` Peter Maydell
2024-02-12 11:24 ` Yoshinori Sato
2024-02-08 18:12 ` [PATCH v3 03/11] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary Philippe Mathieu-Daudé
2024-02-09 11:29 ` Peter Maydell
2024-02-12 11:25 ` Yoshinori Sato
2024-02-08 18:12 ` [PATCH v3 04/11] hw/i386/pc_q35: Realize LPC PCI function before accessing it Philippe Mathieu-Daudé
2024-02-08 18:29 ` BALATON Zoltan
2024-02-08 18:12 ` [PATCH v3 05/11] hw/ppc/prep: Realize ISA bridge " Philippe Mathieu-Daudé
2024-02-09 11:29 ` Peter Maydell
2024-02-09 21:29 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 06/11] hw/misc/macio: Realize IDE controller " Philippe Mathieu-Daudé
2024-02-08 18:33 ` BALATON Zoltan
2024-02-09 6:40 ` Philippe Mathieu-Daudé
2024-02-09 21:32 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 07/11] hw/sh4/r2d: " Philippe Mathieu-Daudé
2024-02-09 11:30 ` Peter Maydell
2024-02-12 12:48 ` Yoshinori Sato
2024-05-03 21:34 ` Guenter Roeck
2024-02-08 18:12 ` [PATCH v3 08/11] hw/sparc/sun4m: Realize DMA " Philippe Mathieu-Daudé
2024-02-09 11:37 ` Peter Maydell
2024-02-09 22:37 ` Mark Cave-Ayland
2024-02-09 21:38 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 09/11] hw/sparc/leon3: Realize GRLIB IRQ " Philippe Mathieu-Daudé
2024-02-09 11:38 ` Peter Maydell
2024-02-09 21:39 ` Mark Cave-Ayland
2024-02-08 18:12 ` [PATCH v3 10/11] hw/sparc/leon3: Initialize GPIO before realizing CPU devices Philippe Mathieu-Daudé
2024-02-09 11:35 ` Peter Maydell
2024-02-09 21:48 ` Mark Cave-Ayland [this message]
2024-02-08 18:12 ` [PATCH v3 11/11] hw/sparc64/cpu: " Philippe Mathieu-Daudé
2024-02-09 11:34 ` Peter Maydell
2024-02-09 22:01 ` Mark Cave-Ayland
2024-02-13 13:00 ` Philippe Mathieu-Daudé
2024-02-09 21:49 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075417ae-151f-46d2-a59b-db36aa20418f@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=chouteau@adacore.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=konrad.frederic@yahoo.fr \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhao1.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).