From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 00/11] media: renesas: rcar-csi2: Use the subdev active state
Date: Fri, 10 May 2024 02:06:04 +0300 [thread overview]
Message-ID: <20240509230604.GC32013@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240509224848.GV1385281@ragnatech.se>
On Fri, May 10, 2024 at 12:48:48AM +0200, Niklas Söderlund wrote:
> On 2024-05-09 23:51:29 +0300, Laurent Pinchart wrote:
> > On Thu, May 09, 2024 at 06:13:50PM +0200, Jacopo Mondi wrote:
> > > v2->v3:
> > > - rcar-csi2: Collect v2.2 of [4/11]
> > > - adv748x: enum_mbus_code: reduce the number of formats to the ones supported
> > > by the HDMI and Analog front ends;
> > > - adv748x: enum_mbus_code: enumerate all formats on sink pad; enumerate the
> > > active format on the source pad
> > > - max9286: Apply the format to all pads to enforce all links to have the same
> > > format
> > > - max9286: Remove max9286_set_fsync_period() from setup
> > >
> > > v2->v1:
> > > - Remove "media: adv748x-csi2: Initialize subdev format"
> > > - Add "media: adv748x-afe: Use 1X16 media bus code"
> > > - Tested with CVBS
> > > - address comments from Laurent and Niklas
> > >
> > > A branch is available at
> > > https://git.kernel.org/pub/scm/linux/kernel/git/jmondi/linux.git/
> > > jmondi/renesas-drivers-2024-04-23-v6.9-rc5/multistream-prep
> > >
> > > As a follow-up to the recently sent
> > > "media: renesas: rcar-csi2: Support multiple streams" series, this smaller
> > > version collects some fixes and implement usage of the subdev active state
> > > to simplify the R-Car CSI-2, ADV748x and MAX9286 drivers implementations.
> > >
> > > Tested with GMSL on Eagle V3M
> > > Tested with HDMI on Salvator-X
> > > Tested with CVBS on Salvator-X
> > > Boot tested on WhiteHawk V4H
> >
> > Niklas, would you be able to runtime-test this on V4H ? The series is
> > otherwise ready to be merged in my opinion.
>
> I have run-time tested this on Gen4 and it works as expected. I also
> tested on Gen2 and Gen3 and all looks good.
Can I add your Tested-by ? :-)
> Patch 7 needs to be moved earlier in the series to avoid breaking git
> bisect, but that move causes no conflicts so should be easy. With that
> fixed I too think this is ready to be merged. Nice work Jacopo!
I've reordered the patches in my tree already.
> > > Jacopo Mondi (11):
> > > media: rcar-vin: Fix YUYV8_1X16 handling for CSI-2
> > > media: rcar-csi2: Disable runtime_pm in probe error
> > > media: rcar-csi2: Cleanup subdevice in remove()
> > > media: rcar-csi2: Use the subdev active state
> > > media: adv748x-csi2: Implement enum_mbus_codes
> > > media: adv748x-csi2: Validate the image format
> > > media: adv748x-csi2: Use the subdev active state
> > > media: adv748x-afe: Use 1X16 media bus code
> > > media: max9286: Fix enum_mbus_code
> > > media: max9286: Use the subdev active state
> > > media: max9286: Use frame interval from subdev state
> > >
> > > drivers/media/i2c/adv748x/adv748x-afe.c | 4 +-
> > > drivers/media/i2c/adv748x/adv748x-csi2.c | 145 +++++++++-----
> > > drivers/media/i2c/adv748x/adv748x.h | 1 -
> > > drivers/media/i2c/max9286.c | 182 +++++++-----------
> > > drivers/media/platform/renesas/rcar-csi2.c | 155 +++++++++------
> > > .../platform/renesas/rcar-vin/rcar-dma.c | 16 +-
> > > 6 files changed, 271 insertions(+), 232 deletions(-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-05-09 23:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 16:13 [PATCH v3 00/11] media: renesas: rcar-csi2: Use the subdev active state Jacopo Mondi
2024-05-09 16:13 ` [PATCH v3 01/11] media: rcar-vin: Fix YUYV8_1X16 handling for CSI-2 Jacopo Mondi
2024-05-09 22:34 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 02/11] media: rcar-csi2: Disable runtime_pm in probe error Jacopo Mondi
2024-05-09 22:35 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 03/11] media: rcar-csi2: Cleanup subdevice in remove() Jacopo Mondi
2024-05-09 22:35 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 04/11] media: rcar-csi2: Use the subdev active state Jacopo Mondi
2024-05-09 22:40 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 05/11] media: adv748x-csi2: Implement enum_mbus_codes Jacopo Mondi
2024-05-09 20:44 ` Laurent Pinchart
2024-05-09 22:43 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 06/11] media: adv748x-csi2: Validate the image format Jacopo Mondi
2024-05-09 22:42 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 07/11] media: adv748x-csi2: Use the subdev active state Jacopo Mondi
2024-05-09 22:45 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 08/11] media: adv748x-afe: Use 1X16 media bus code Jacopo Mondi
2024-05-09 21:45 ` Niklas Söderlund
2024-05-09 16:13 ` [PATCH v3 09/11] media: max9286: Fix enum_mbus_code Jacopo Mondi
2024-05-09 16:14 ` [PATCH v3 10/11] media: max9286: Use the subdev active state Jacopo Mondi
2024-05-09 20:46 ` Laurent Pinchart
2024-05-09 16:14 ` [PATCH v3 11/11] media: max9286: Use frame interval from subdev state Jacopo Mondi
2024-05-09 20:51 ` [PATCH v3 00/11] media: renesas: rcar-csi2: Use the subdev active state Laurent Pinchart
2024-05-09 22:48 ` Niklas Söderlund
2024-05-09 23:06 ` Laurent Pinchart [this message]
2024-05-10 8:36 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509230604.GC32013@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).