From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A46C786245; Thu, 9 May 2024 23:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715295978; cv=none; b=Y+Nqk2o6UN5xVYJlGwalmGcf9szlGspQEnr3OQS7Y0RA70Rhm9bRvu3pydnqyIxQ+6kSUyPnGQKhWb9113DsQUl7nF9xNB29NkgM4VdTKhP8/N2yibZMw7isgt4aGCeI5PZSYeAaHjn/SeP5cyLFK3IQMxs9Qw3TK+EdLK3j/9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715295978; c=relaxed/simple; bh=OmUB9YDJ0kyiTgoYjtxQpv9XeDeHNTQIrS8WpnhiCDw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jdl++YEGL4WcnWYEt6WEsEer/qi7b/ablBdpIgU2w37JF/OFYKr/tUrmSlm5QTomc+SVoWgbPZHHAPmErbbYEqCtl2geNw55qal9PR5wm3T2leQjlbP1L/yHBNPHhe+qCnB1H/W5m6T+kdmxlX6X6a7Fb1SkanGCBhMoF01WtKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=StOp4TwT; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="StOp4TwT" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AE5C81495; Fri, 10 May 2024 01:06:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1715295970; bh=OmUB9YDJ0kyiTgoYjtxQpv9XeDeHNTQIrS8WpnhiCDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=StOp4TwTectYXgA9wu6NypNiclIfTIm0VQokqfG0O/mTDZuersdTKO+eDggtI+9Nc aAKojj6MhS2ElCWtjmCl0tirMgBYxrSY/Iv4hNwyvV5U5VQq/sUvJAhAxNzZP+6KlT +apWWLc6Geo3z7vqQp+j7pYYsIGfcW38JrDwloRI= Date: Fri, 10 May 2024 02:06:04 +0300 From: Laurent Pinchart To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Jacopo Mondi , Sakari Ailus , Kieran Bingham , Tomi Valkeinen , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 00/11] media: renesas: rcar-csi2: Use the subdev active state Message-ID: <20240509230604.GC32013@pendragon.ideasonboard.com> References: <20240509161403.111789-1-jacopo.mondi@ideasonboard.com> <20240509205129.GD6407@pendragon.ideasonboard.com> <20240509224848.GV1385281@ragnatech.se> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240509224848.GV1385281@ragnatech.se> On Fri, May 10, 2024 at 12:48:48AM +0200, Niklas Söderlund wrote: > On 2024-05-09 23:51:29 +0300, Laurent Pinchart wrote: > > On Thu, May 09, 2024 at 06:13:50PM +0200, Jacopo Mondi wrote: > > > v2->v3: > > > - rcar-csi2: Collect v2.2 of [4/11] > > > - adv748x: enum_mbus_code: reduce the number of formats to the ones supported > > > by the HDMI and Analog front ends; > > > - adv748x: enum_mbus_code: enumerate all formats on sink pad; enumerate the > > > active format on the source pad > > > - max9286: Apply the format to all pads to enforce all links to have the same > > > format > > > - max9286: Remove max9286_set_fsync_period() from setup > > > > > > v2->v1: > > > - Remove "media: adv748x-csi2: Initialize subdev format" > > > - Add "media: adv748x-afe: Use 1X16 media bus code" > > > - Tested with CVBS > > > - address comments from Laurent and Niklas > > > > > > A branch is available at > > > https://git.kernel.org/pub/scm/linux/kernel/git/jmondi/linux.git/ > > > jmondi/renesas-drivers-2024-04-23-v6.9-rc5/multistream-prep > > > > > > As a follow-up to the recently sent > > > "media: renesas: rcar-csi2: Support multiple streams" series, this smaller > > > version collects some fixes and implement usage of the subdev active state > > > to simplify the R-Car CSI-2, ADV748x and MAX9286 drivers implementations. > > > > > > Tested with GMSL on Eagle V3M > > > Tested with HDMI on Salvator-X > > > Tested with CVBS on Salvator-X > > > Boot tested on WhiteHawk V4H > > > > Niklas, would you be able to runtime-test this on V4H ? The series is > > otherwise ready to be merged in my opinion. > > I have run-time tested this on Gen4 and it works as expected. I also > tested on Gen2 and Gen3 and all looks good. Can I add your Tested-by ? :-) > Patch 7 needs to be moved earlier in the series to avoid breaking git > bisect, but that move causes no conflicts so should be easy. With that > fixed I too think this is ready to be merged. Nice work Jacopo! I've reordered the patches in my tree already. > > > Jacopo Mondi (11): > > > media: rcar-vin: Fix YUYV8_1X16 handling for CSI-2 > > > media: rcar-csi2: Disable runtime_pm in probe error > > > media: rcar-csi2: Cleanup subdevice in remove() > > > media: rcar-csi2: Use the subdev active state > > > media: adv748x-csi2: Implement enum_mbus_codes > > > media: adv748x-csi2: Validate the image format > > > media: adv748x-csi2: Use the subdev active state > > > media: adv748x-afe: Use 1X16 media bus code > > > media: max9286: Fix enum_mbus_code > > > media: max9286: Use the subdev active state > > > media: max9286: Use frame interval from subdev state > > > > > > drivers/media/i2c/adv748x/adv748x-afe.c | 4 +- > > > drivers/media/i2c/adv748x/adv748x-csi2.c | 145 +++++++++----- > > > drivers/media/i2c/adv748x/adv748x.h | 1 - > > > drivers/media/i2c/max9286.c | 182 +++++++----------- > > > drivers/media/platform/renesas/rcar-csi2.c | 155 +++++++++------ > > > .../platform/renesas/rcar-vin/rcar-dma.c | 16 +- > > > 6 files changed, 271 insertions(+), 232 deletions(-) -- Regards, Laurent Pinchart