From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
Cc: git@vger.kernel.org,
"Jonathan Davies" <jonathan.davies@nutanix.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>,
"Denton Liu" <liu.denton@gmail.com>,
"Linus Arver" <linusa@google.com>,
"Florian Schmidt" <flosch@nutanix.com>
Subject: Re: [PATCH] wt-status: Don't find scissors line beyond buf len
Date: Thu, 07 Mar 2024 13:24:09 -0800 [thread overview]
Message-ID: <xmqqo7bpka6e.fsf@gitster.g> (raw)
In-Reply-To: <f8de2b3a-9e12-49fe-a7d9-481317f10c4d@app.fastmail.com> (Kristoffer Haugsbakk's message of "Thu, 07 Mar 2024 22:15:12 +0100")
"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> On Thu, Mar 7, 2024, at 21:47, Junio C Hamano wrote:
>> Signed-off-by: Florian Schmidt <flosch@nutanix.com>
>> Reviewed-by: Jonathan Davies <jonathan.davies@nutanix.com>
>> [jc: tweaked the commit log message and the implementation a bit]
>
> Just a question. Given the imperative mood principle/rule, why are these
> bracket changelog lines always written in the past tense?
These are not giving orders to the code to become like so. The
trailer block records what happend to the patch in chronological
order---think of those written there at one level higher level,
"meta" comments.
next prev parent reply other threads:[~2024-03-07 21:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:37 [PATCH] wt-status: Don't find scissors line beyond buf len Florian Schmidt
2024-03-07 19:20 ` Junio C Hamano
2024-03-07 20:47 ` Junio C Hamano
2024-03-07 21:09 ` Eric Sunshine
2024-03-07 21:15 ` Kristoffer Haugsbakk
2024-03-07 21:24 ` Junio C Hamano [this message]
2024-03-07 21:26 ` Eric Sunshine
2024-03-07 21:30 ` Kristoffer Haugsbakk
2024-03-08 9:08 ` Florian Schmidt
2024-03-08 15:26 ` Junio C Hamano
2024-03-08 17:43 ` Florian Schmidt
2024-04-06 1:37 ` Linus Arver
2024-03-07 19:35 ` Junio C Hamano
2024-03-08 9:13 ` Florian Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7bpka6e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=flosch@nutanix.com \
--cc=git@vger.kernel.org \
--cc=jonathan.davies@nutanix.com \
--cc=linusa@google.com \
--cc=liu.denton@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).