From: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
To: "Eric Sunshine" <sunshine@sunshineco.com>
Cc: git@vger.kernel.org,
"Jonathan Davies" <jonathan.davies@nutanix.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>,
"Denton Liu" <liu.denton@gmail.com>,
"Linus Arver" <linusa@google.com>,
"Florian Schmidt" <flosch@nutanix.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] wt-status: Don't find scissors line beyond buf len
Date: Thu, 07 Mar 2024 22:30:33 +0100 [thread overview]
Message-ID: <6acdc464-825e-48bd-a2d6-97671b58f879@app.fastmail.com> (raw)
In-Reply-To: <CAPig+cRNa22A=fEmc__JvEjYiVF-QG8o7w0gukhbeL3e-PwVkA@mail.gmail.com>
On Thu, Mar 7, 2024 at 4:24 PM Junio C Hamano <gitster@pobox.com> wrote:
>> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
>> > On Thu, Mar 7, 2024, at 21:47, Junio C Hamano wrote:
>> >> [jc: tweaked the commit log message and the implementation a bit]
>> >
>> > Just a question. Given the imperative mood principle/rule, why are these
>> > bracket changelog lines always written in the past tense?
>>
>> These are not giving orders to the code to become like so. The
>> trailer block records what happend to the patch in chronological
>> order---think of those written there at one level higher level,
>> "meta" comments.
And when I think about it the trailers themselves are of course in the
past tense…
Thanks guys
On Thu, Mar 7, 2024, at 22:26, Eric Sunshine wrote:
>
> Also, they are not always written in past tense[*].
>
> [*]:
> https://lore.kernel.org/git/20240112171910.11131-1-ericsunshine@charter.net/
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-03-07 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:37 [PATCH] wt-status: Don't find scissors line beyond buf len Florian Schmidt
2024-03-07 19:20 ` Junio C Hamano
2024-03-07 20:47 ` Junio C Hamano
2024-03-07 21:09 ` Eric Sunshine
2024-03-07 21:15 ` Kristoffer Haugsbakk
2024-03-07 21:24 ` Junio C Hamano
2024-03-07 21:26 ` Eric Sunshine
2024-03-07 21:30 ` Kristoffer Haugsbakk [this message]
2024-03-08 9:08 ` Florian Schmidt
2024-03-08 15:26 ` Junio C Hamano
2024-03-08 17:43 ` Florian Schmidt
2024-04-06 1:37 ` Linus Arver
2024-03-07 19:35 ` Junio C Hamano
2024-03-08 9:13 ` Florian Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6acdc464-825e-48bd-a2d6-97671b58f879@app.fastmail.com \
--to=code@khaugsbakk.name \
--cc=flosch@nutanix.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathan.davies@nutanix.com \
--cc=linusa@google.com \
--cc=liu.denton@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).