From: Linus Arver <linusa@google.com>
To: Junio C Hamano <gitster@pobox.com>, Florian Schmidt <flosch@nutanix.com>
Cc: git@vger.kernel.org,
Jonathan Davies <jonathan.davies@nutanix.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH] wt-status: Don't find scissors line beyond buf len
Date: Fri, 05 Apr 2024 18:37:29 -0700 [thread overview]
Message-ID: <owlyo7ans23q.fsf@fine.c.googlers.com> (raw)
In-Reply-To: <xmqq34t1n91w.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> Florian Schmidt <flosch@nutanix.com> writes:
>
>> It seems sensible to expect that wt_status_locate_end() should honour
>> the length parameter passed in, and doing so fixes this issue.
>
> Thanks. This is an ancient bug, not a retression from recent
> changes to the trailer library [linusa CC'ed to save him from
> wasting his time wondering if he broke anything].
Ack. Very much appreciated!
Also, sorry for not responding sooner --- my email search queries so far
were using "replied" as a condition so I only saw this just now while
searching for the "trailer" term.
Cheers
next prev parent reply other threads:[~2024-04-06 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:37 [PATCH] wt-status: Don't find scissors line beyond buf len Florian Schmidt
2024-03-07 19:20 ` Junio C Hamano
2024-03-07 20:47 ` Junio C Hamano
2024-03-07 21:09 ` Eric Sunshine
2024-03-07 21:15 ` Kristoffer Haugsbakk
2024-03-07 21:24 ` Junio C Hamano
2024-03-07 21:26 ` Eric Sunshine
2024-03-07 21:30 ` Kristoffer Haugsbakk
2024-03-08 9:08 ` Florian Schmidt
2024-03-08 15:26 ` Junio C Hamano
2024-03-08 17:43 ` Florian Schmidt
2024-04-06 1:37 ` Linus Arver [this message]
2024-03-07 19:35 ` Junio C Hamano
2024-03-08 9:13 ` Florian Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=owlyo7ans23q.fsf@fine.c.googlers.com \
--to=linusa@google.com \
--cc=flosch@nutanix.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathan.davies@nutanix.com \
--cc=liu.denton@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).